-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow expand "AccordionItem" programmatically #13
Merged
vincentaudebert
merged 11 commits into
springload:master
from
epotockiy:feature/programmatically-expand
Sep 13, 2017
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5e973b7
Allow expand "AccordionItem" programmatically
epotockiy 0f4775f
moving isArraysEqual into utils folder so it's easier to test
vincentaudebert 50d5e8e
Update test, to coverage accorionItems prop functionality
d28cffe
Add more branches coverage for activeItems prop
be527a5
Update README to mention activeItems
vincentaudebert a3adfaf
Changes function name to be clearer
vincentaudebert 556ba56
Adds customKey documentation
vincentaudebert 7f2baec
No need for complex syntax
vincentaudebert bef9bcd
Adds example for changing active items programmatically
vincentaudebert 27a965c
Merge remote-tracking branch 'upstream/master' into feature/programma…
vincentaudebert fb478c7
Updates snapshot after merge from master
vincentaudebert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,6 +7,10 @@ | |
margin-top: 1.875rem; | ||
} | ||
|
||
.u-margin-right { | ||
margin-right: 1.875rem; | ||
} | ||
|
||
.block { | ||
padding: 1.25rem; | ||
} | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have some other documentation mentioning this
customKey
prop.