Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #767, duplicate @JsonProperty #1045

Merged
merged 2 commits into from
Nov 16, 2015
Merged

Conversation

mrestivill
Copy link
Contributor

There is a duplicated @JsonProperty on the file, could you integrate it? Please

@@ -71,7 +71,7 @@ public String getClientSecret() {
return clientSecret;
}

@JsonProperty("apiKey")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiKey duplicated

@dilipkrish
Copy link
Member

@glarfs gaah! thats some copy paste error right there! Thanks for catching that... looks like it has failing tests tho'

@mrestivill
Copy link
Contributor Author

The test on my local branch(which is pointing to master) without this commit and it fails on the same point, it's strange. Seems that the code which is failing test is another commit.

@n0mer
Copy link
Contributor

n0mer commented Nov 12, 2015

@glarfs @dilipkrish there are definitely 2 failing tests

image

@dilipkrish dilipkrish added the PR label Nov 15, 2015
@dilipkrish dilipkrish added this to the 2.3.0 milestone Nov 15, 2015
@mrestivill
Copy link
Contributor Author

There where an issue with tests, Now the tests are fixed

@mrestivill mrestivill closed this Nov 16, 2015
@mrestivill mrestivill reopened this Nov 16, 2015
dilipkrish added a commit that referenced this pull request Nov 16, 2015
@dilipkrish dilipkrish merged commit 62db367 into springfox:master Nov 16, 2015
@dilipkrish
Copy link
Member

Thanks! 👍

@n0mer
Copy link
Contributor

n0mer commented Nov 16, 2015

@dilipkrish , do you publish snapshot , RC or milestone builds somewhere?

i'm eager to try this :)

@dilipkrish
Copy link
Member

A snapshot is automatically published with every build. Details in our documentation on coordinates of the snapshot versions

@dilipkrish
Copy link
Member

Actually 2.2.2 was a bad build as regards documentation 😖 The snapshot documentation is probably better

@mrestivill
Copy link
Contributor Author

Hi, this fix could be applied also on 2.2.x branch, When are you releasing a new version with this fix?
It would be nice to have an snapshot with this fix as 2.2.3-SNAPSHOT.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants