Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record remoteAddress in unmapped mapper #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

evisong
Copy link

@evisong evisong commented Sep 28, 2018

Hi, team,

In my use case, remoteAddress helps a lot when analyzing beacons. It seems this argument is passed into map function but it's never used yet: https://github.com/springernature/boomcatch/blob/master/src/index.js#L656

I'm adding it to unmapped mapper.

Could you kindly let me know if it's proper to do so, and if yes whether should I add to other mappers as well?

Thanks.

@josebolos
Copy link
Contributor

Hi @evisong,

Thanks for your PRs! I'll try to have a look at them as soon as possible.

@evisong
Copy link
Author

evisong commented Jan 2, 2019

Hi @evisong,

Thanks for your PRs! I'll try to have a look at them as soon as possible.

Hi, @josebolos,

May I ask if there is any progress yet? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants