Machine from StateMachineBuilder may prevent jvm exit #624
Labels
type/enhancement
Is an enhancement request
Comments
RenanSFreitas
pushed a commit
to RenanSFreitas/spring-statemachine
that referenced
this issue
Aug 21, 2022
ConcurrentTaskScheduler doesn't expose any way for it's inner executor to be shutdown, when it's instance is created with the default constructor. This can lead to a scenario where a library user ends up with many unused threads with no clear cues about where they came from. This commit replaces the usage of ConcurrentTaskScheduler with ThreadPoolTaskScheduler, a type of similar semantics but better API, which includes methods for managing its internal resources lifecycle. Also it implements spring-beans interfaces which makes it more suitable to be managed by a Spring application context. - Fixes spring-projects#624
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On default
TaskScheduleris configured to useorg.springframework.scheduling.concurrent.ConcurrentTaskSchedulerwhich then gets used with state actions. Unfortunate side effect for this is that jvm shutdown will get blocked. While workaround is to replace your ownTaskScheduler, we should figure out how to change this so that default functionality would not be so bad.The text was updated successfully, but these errors were encountered: