Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten JPA table names #469

Closed
jvalkeal opened this issue Jan 17, 2018 · 1 comment
Closed

Shorten JPA table names #469

jvalkeal opened this issue Jan 17, 2018 · 1 comment
Labels
type/enhancement Is an enhancement request
Milestone

Comments

@jvalkeal
Copy link
Contributor

We need to do an unfortunate breaking change as used table names derived from entity classes may become too long and is causing issues with databases if there are limitations. For example oracle usually limits all objects to max 30 chars, thus making these unusable.

jpa_repository_state_deferred_events
jpa_repository_state_entry_actions
jpa_repository_state_exit_actions
jpa_repository_state_state_actions
jpa_repository_transition_actions

Essentially plan is to remove jpa_repository_ prefix which then gives more freedom for users to prefix their own tables with custom naming. Using custom jpa naming to add a prefix would then be migration path to 1.2.8 if user wants to keep old tables.

@jvalkeal jvalkeal added the type/enhancement Is an enhancement request label Jan 17, 2018
@jvalkeal jvalkeal added this to the 1.2.8.RELEASE milestone Jan 17, 2018
jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Jan 17, 2018
- Modify existing JPA entity classes to
  have a fixed names for constraints and
  foreign key. Also name used tables so that
  we don't get crazy long names which are
  causing issues with some DB's
- Fixes spring-projects#468
- Fixes spring-projects#469
@jvalkeal
Copy link
Contributor Author

Closing per 0f7624a

jvalkeal added a commit to jvalkeal/spring-statemachine that referenced this issue Jan 23, 2018
- Modify existing JPA entity classes to
  have a fixed names for constraints and
  foreign key. Also name used tables so that
  we don't get crazy long names which are
  causing issues with some DB's
- Fixes spring-projects#468
- Fixes spring-projects#469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Is an enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant