Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jline 3.24.1 #901

Closed
jvalkeal opened this issue Nov 2, 2023 · 2 comments
Closed

Upgrade jline 3.24.1 #901

jvalkeal opened this issue Nov 2, 2023 · 2 comments
Labels
area/dependencies Belongs project dependencies branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch for/backport For backporting
Milestone
3.2.0-M3

Comments

@jvalkeal
Copy link
Contributor

jvalkeal commented Nov 2, 2023

No description provided.

@jvalkeal jvalkeal added the area/dependencies Belongs project dependencies label Nov 2, 2023
@jvalkeal
Copy link
Contributor Author

jvalkeal commented Nov 2, 2023

Just adding a note here as something happens in tests if jna is in classpath. Actual shell samples seem to run fine if compiling without running tests:

> Task :spring-shell-core:compileTestJava
Note: /home/jvalkealahti/repos/spring/spring-shell/main/spring-shell-core/src/test/java/org/springframework/shell/component/support/SelectorListTests.java uses unchecked or unsafe operations.
/home/jvalkealahti/.sdkman/candidates/java/22.3.r17-nik/bin/java: symbol lookup error: /tmp/jlinenative-3.24.1-3bd24c3fe1702ab0-libjlinenative.so: undefined symbol: openpty

> Task :spring-shell-samples:spring-shell-sample-commands:test FAILED

FAILURE: Build failed with an exception.

@jvalkeal jvalkeal added this to the 3.2.0-RC1 milestone Nov 3, 2023
@jvalkeal
Copy link
Contributor Author

jvalkeal commented Nov 3, 2023

The error above is related to jline/jline3#896. We can work around it in test system by disabling jni provider. I'm also thinking to disable it on default in terminal auto-config.

@jvalkeal jvalkeal mentioned this issue Nov 3, 2023
Closed
jvalkeal added a commit to jvalkeal/spring-shell that referenced this issue Nov 3, 2023
@jvalkeal
Upgrade jline 3.24.1
efdf83a 
- Disable jni terminal provider in test ShellAutoConfiguration
  like it's done for jna/jansi
- Default TerminalBuilder system outpu to SysOut to restore
  writing to stdout instead of stderr when redirect exists
- Relates spring-projects#891
- Relates spring-projects#901
@jvalkeal jvalkeal added for/backport For backporting branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch labels Nov 3, 2023
This was referenced Nov 3, 2023
Closed
Closed
Closed
jvalkeal added a commit that referenced this issue Nov 3, 2023
@jvalkeal
Upgrade jline 3.24.1
46b38a0 
- Disable jni terminal provider in test ShellAutoConfiguration
  like it's done for jna/jansi
- Default TerminalBuilder system outpu to SysOut to restore
  writing to stdout instead of stderr when redirect exists
- Backport #891
- Backport #901
- Fixes #913
- Fixes #910
jvalkeal added a commit that referenced this issue Nov 3, 2023
@jvalkeal
Upgrade jline 3.24.1
ae6fbdc 
- Disable jni terminal provider in test ShellAutoConfiguration
  like it's done for jna/jansi
- Default TerminalBuilder system outpu to SysOut to restore
  writing to stdout instead of stderr when redirect exists
- Backport #891
- Backport #901
- Fixes #914
- Fixes #911
jvalkeal added a commit that referenced this issue Nov 3, 2023
@jvalkeal
Upgrade jline 3.24.1
1f4eb5b 
- Default TerminalBuilder system outpu to SysOut to restore
  writing to stdout instead of stderr when redirect exists
- Backport #891
- Backport #901
- Fixes #915
- Fixes #912
@jvalkeal jvalkeal closed this as completed Nov 3, 2023
@jvalkeal jvalkeal modified the milestones: 3.2.0-RC1, 3.2.0-M3 Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dependencies Belongs project dependencies branch/2.1.x Issue for a branch branch/3.0.x Issue for a branch branch/3.1.x Issue for a branch for/backport For backporting
Projects
None yet
Milestone
3.2.0-M3
Development

No branches or pull requests
1 participant
@jvalkeal