Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasAnyRole and hasAnyAuthority to authorizeRequests in Kotlin DSL #8926

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Add hasAnyRole and hasAnyAuthority to authorizeRequests in Kotlin DSL #8926

merged 2 commits into from
Aug 11, 2020

Conversation

koishikawa11
Copy link
Contributor

@koishikawa11 koishikawa11 commented Aug 5, 2020 •
edited
Loading

Closes gh-8892

@pivotal-issuemaster
Copy link

@koishikawa11 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 5, 2020
@pivotal-issuemaster
Copy link

@koishikawa11 Thank you for signing the Contributor License Agreement!

eleftherias
eleftherias suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @koishikawa11!

I have one small comment about the commit message.

Please add Closes gh-8892 at the end of the commit message, on a new line, so that the issue is automatically closed.

@eleftherias eleftherias self-assigned this Aug 6, 2020
@eleftherias eleftherias added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 6, 2020
@eleftherias eleftherias merged commit be6d2f1 into spring-projects:master Aug 11, 2020
@eleftherias
Copy link
Contributor

Thanks for the PR @koishikawa11! This is now merged into master.

@eleftherias eleftherias added the status: duplicate A duplicate of another issue label Aug 11, 2020
@eleftherias eleftherias added this to the 5.4.0 milestone Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias Awaiting requested review from eleftherias

Assignees

@eleftherias eleftherias

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Add hasAnyAuthority(String...) and hasAnyRole(String...) to authorizeRequests in Kotlin DSL
4 participants
@koishikawa11 @pivotal-issuemaster @eleftherias @spring-projects-issues