Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LogoutSuccessEvent #7306

Closed

Conversation

okohub
Copy link
Contributor

@okohub okohub commented Aug 23, 2019

LogoutSuccessEvent is a simple AbstractAuthenticationEvent implementation which indicates successful logout.

By default, LogoutConfigurer will add a new LogoutHandler called LogoutSuccessEventPublishingLogoutHandler to publish this event.

This PR will also fix ConcurrentSessionFilter's composite logoutHandler, now will get LogoutHandler instances from LogoutConfigurer for consistency.

Fixes gh-2900

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 23, 2019
@okohub okohub force-pushed the introduce-logout-success-event branch 3 times, most recently from 8536ccc to b98e6c0 Compare August 23, 2019 16:02
LogoutSuccessEvent is a simple AbstractAuthenticationEvent implementation which indicates successful logout.

By default, LogoutConfigurer will add a new LogoutHandler called LogoutSuccessEventPublishingLogoutHandler to publish this event.

This PR will also fix ConcurrentSessionFilter's composite logoutHandler, now will get LogoutHandler instances from LogoutConfigurer for consistency.

Fixes spring-projectsgh-2900
@okohub okohub force-pushed the introduce-logout-success-event branch from b98e6c0 to 6d1e68a Compare August 23, 2019 16:03
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 18, 2019
@rwinch rwinch self-assigned this Sep 18, 2019
@rwinch rwinch added this to the 5.2.0 milestone Sep 18, 2019
@rwinch
Copy link
Member

rwinch commented Sep 18, 2019

Thanks for the PR this was merged into master via 034b5e9

@rwinch rwinch closed this Sep 18, 2019
@rwinch rwinch added the status: duplicate A duplicate of another issue label Sep 18, 2019
@okohub okohub deleted the introduce-logout-success-event branch September 19, 2019 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEC-2680: Fire an event when logout has finished
3 participants