Cleanup Code Style Issues #7238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reports methods and constructors where constant charset String literal is used (like "UTF-8") which could be replaced with a predefined Charset object like StandardCharsets.UTF_8. This may work a little bit faster, because charset lookup becomes unnecessary. Also catching UnsupportedEncodingException may become unnecessary as well. In this case the catch block will be removed automatically.
Reports any type parameters and wildcard type arguments explicitly declared to extend java.lang.Object.
spring-projects-issues
added
the
status: waiting-for-triage
rwinch
added
type: enhancement
rwinch
requested changes
Aug 9, 2019
There was a problem hiding this comment.
Thanks for the PR @larsgrefer! Overall it looks good, but it appears that there are some checkstyle issues still. You can run ./gradlew checkstyleMain checkstyleTest to get the results.
|
Seems like checkstyle found even more redundant modifiers 😆 |
larsgrefer
force-pushed
the
cleanup/codeStyleIssues
branch
from
dcd3c02 to
ec6ca97
Compare
|
Thanks for the PR! This is now merged into master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.