Support nested builder in DSL for reactive apps #7121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
force-pushed
the
gh-7107-server-dsl-nested-builder
branch
from
22a68d0 to
4af9c30
Compare
rwinch
requested changes
Jul 23, 2019
| @@ -49,7 +50,7 @@ | |||
| */ | |||
| public class HeaderSpecTests { | |||
|
|
|||
| private ServerHttpSecurity.HeaderSpec headers = ServerHttpSecurity.http().headers(); | |||
| private ServerHttpSecurity serverHttpSecurity = ServerHttpSecurity.http(); | |||
There was a problem hiding this comment.
To be consistent with the variable we typically use, please change to http. We also use http to make it look similar to the XML based configuration.
eleftherias
force-pushed
the
gh-7107-server-dsl-nested-builder
branch
from
4af9c30 to
a0f4fff
Compare
rwinch
approved these changes
Jul 23, 2019
rwinch
added
in: config
|
Thanks this is now merged into master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gh-7107