Added null checks and tests to constructors #6915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@clementkng Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@clementkng Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
May 29, 2019
There was a problem hiding this comment.
@clementkng thanks for the PR! I've left one piece of feedback inline.
| @Test | ||
| public void authorityWithNullRoleFailsAssertion() { | ||
| try { | ||
| JaasGrantedAuthority authority = |
There was a problem hiding this comment.
Thank you for adding these tests. For consistency with other tests in the codebase, would you please change the way you are handling these exceptions to use AssertJ instead? Something similar to:
assertThatThrownBy(() -> ...)
.isInstanceOf(IllegalArgumentException.class)
RequestKey, JaasGrantedAuthority, and SwitchUserGrantedAuthority assume certain final members are non-null. Issue: spring-projectsgh-6892
clementkng
force-pushed
the
gh-6892-constructor-null-checks
branch
from
947de70 to
a9fbb70
Compare
|
@jzheaux Thanks for the review! I made the changes to the tests. |
jzheaux
approved these changes
May 29, 2019
|
Thanks, @clementkng, this is now merged into |
rwinch
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestKey, JaasGrantedAuthority, and SwitchUserGrantedAuthority
assume certain final members are non-null.
Issue: gh-6892