Add new configuration options for OAuth2LoginSpec #6462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickbr23 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@nickbr23 Thank you for signing the Contributor License Agreement! |
jgrandja
requested changes
Jan 22, 2019
| @@ -53,6 +53,7 @@ | |||
| import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationCodeGrantWebFilter; | |||
There was a problem hiding this comment.
Please update Copyright header to 2019
There was a problem hiding this comment.
Done and updated the unit test in OAuth2LoginTests
jgrandja
added
in: config
jgrandja
changed the title
nickbr23
force-pushed
the
gh-5598-config-options
branch
from
c0185e7 to
a2b8943
Compare
jgrandja
approved these changes
Jan 24, 2019
|
Closed via b581bb7 |
|
Thank you @nickbr23! The commit message didn't exactly follow the expected format. I updated it for you. Please take a look so you know for the next time. I also added javadoc. Thanks again for taking this on and I look forward to seeing some more contributions from you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Oauth2LoginSpec with:
OAuth2LoginSpec.authorizationRequestResolver(ServerOAuth2AuthorizationRequestResolver authorizationRequestResolver)and
OAuth2LoginSpec.authenticationMatcher(ServerWebExchangeMatcher authenticationMatcher)