Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove check for method HttpServletRequest#getHeader and related test #6290

Merged
merged 1 commit into from Dec 18, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 16, 2018

Fixes: gh-6265

@ghost
Copy link
Author

ghost commented Dec 16, 2018

Not sure I understand the travis job. It says it's pending but when I look at details it seems to be in error? Can't find a message though

@jzheaux jzheaux self-assigned this Dec 17, 2018
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 17, 2018
@jzheaux jzheaux added this to the 5.2.0.M1 milestone Dec 17, 2018
@jzheaux
Copy link
Contributor

jzheaux commented Dec 17, 2018

@shawnbiesan Thank you! I think we just need one change, which is to amend the commit message. Ideally, the commit title is under 50 characters, but if you want to be more descriptive than that, then you can add extra information to the commit body.

This will also bump the Travis build, which I'm looking into now.

@ghost
Copy link
Author

ghost commented Dec 18, 2018

OK, length is lessened (I assume force push is the way to go to amend to message? Haven't done a PR/fork on here before?). Looks like travis passed now too

@jzheaux jzheaux merged commit a919b4e into spring-projects:master Dec 18, 2018
@jzheaux
Copy link
Contributor

jzheaux commented Dec 18, 2018

Thanks for the PR, @shawnbiesan! This is now merged into master.

We hope that you will contribute again! Feel free to take any task you like, though we try to mark tasks that are naturally a little better for the community with a help wanted label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Servlet 3.0 Support in CacheControlHeadersWriter
1 participant