Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Path Variables in Message Expressions #6110

Closed
wants to merge 1 commit into from
Closed

Support Path Variables in Message Expressions #6110

wants to merge 1 commit into from

Conversation

dbuos
Copy link
Contributor

@dbuos dbuos commented Nov 18, 2018 •
edited
Loading

Extract path variables expressed in SimpDestinationMessageMatcher's pattern.

Fixes: gh-4469

@dbuos dbuos force-pushed the gh-4469 branch 2 times, most recently from 8dca999 to 698eded Compare November 18, 2018 05:22
rwinch
rwinch requested changes Nov 21, 2018
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Daniel69! I have left comments inline.

...g/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java Outdated Show resolved Hide resolved
...g/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java Show resolved Hide resolved
@dbuos
Support Path Variables in Message Expressions
8ca2446 
Extract path variables expressed in SimpDestinationMessageMatcher's pattern.

Issue: spring-projectsgh-4469
@rwinch rwinch self-assigned this Nov 21, 2018
@rwinch rwinch added in: messaging An issue in spring-security-messaging type: enhancement A general enhancement labels Nov 21, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 21, 2018
@rwinch rwinch modified the milestones: 5.2.0.M1, 5.2.0.M2 Jan 16, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@luc-clement
Copy link

Is this PR ready to be merged or are they still changes awaited ?

@rwinch
Copy link
Member

rwinch commented Jun 7, 2019

Thanks for the PR @dbuos! This is now merged into master and will be part of Spring Security 5.2 via f97ac4d I applied a bit of polish via fcb4def

@rwinch rwinch closed this Jun 7, 2019
@rwinch rwinch added the status: duplicate A duplicate of another issue label Jun 7, 2019
@rwinch rwinch mentioned this pull request Jun 7, 2019
Closed
@dbuos dbuos deleted the gh-4469 branch October 11, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch approved these changes

Assignees

@rwinch rwinch

Labels
in: messaging An issue in spring-security-messaging status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M3
Development

Successfully merging this pull request may close these issues.

WebSocket matchers ignore parameters
4 participants
@dbuos @luc-clement @rwinch @jgrandja