Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in the Servlet and Reactive Observability documents #15692

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

ximinghui
Copy link
Contributor

In the Manual Configuration section of the Servlet and Reactive Observability documents, the ObservationRegistry class is incorrectly written: Type 'io. micrometer. observation. ObservationRegistry' does not have type parameters.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 26, 2024
@jzheaux jzheaux self-assigned this Aug 26, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 26, 2024
@jzheaux jzheaux added this to the 6.4.0-M4 milestone Aug 26, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Aug 26, 2024

Hi, @ximinghui! Thanks for the PR.

Will you please update your commit message to be a bit shorter? This helps when people are reviewing the commit history in their IDE. I've updated your other PR to demonstrate an example.

If you want, you can add an explanation on a separate line like this:

A Short Title

A description that line-breaks at about 72 characters so that it
is easier to read in IDEs.

@jzheaux jzheaux merged commit 0b98eb4 into spring-projects:main Sep 3, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Sep 3, 2024

Thanks, @ximinghui! This is now merged into main

@ximinghui ximinghui deleted the fix-typo-observability-doc branch September 4, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants