-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix corrupted saml2 metadata once special characters are present #13777
fix corrupted saml2 metadata once special characters are present #13777
Conversation
@JannickWeisshaupt Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@JannickWeisshaupt Thank you for signing the Contributor License Agreement! |
Hi @JannickWeisshaupt, can you add a test that verifies the correct behavior? In addition to that, can you please target the |
c5c40e1
to
c820dfe
Compare
Hi @marcusdacoregio, should be done! |
Nice @JannickWeisshaupt. In preparation for merging, can you please squash your commits into one? Ideally, the single commit should have the following message:
|
9f5771b
to
778e187
Compare
Commits are squashed @marcusdacoregio |
Thanks, @JannickWeisshaupt. This is now merged into |
Fixes corrupted Saml2Metadata once special characters are present. The cause of this bug is that the length in bytes, which is correct for the content length is not equal to the java string length.
See Issue #13776