Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenSamlAuthenticationProvider should not throw AuthenticationServiceException #7377

Closed
jzheaux opened this issue Sep 5, 2019 · 0 comments
Closed

OpenSamlAuthenticationProvider should not throw AuthenticationServiceException #7377

jzheaux opened this issue Sep 5, 2019 · 0 comments
Assignees
@fhanik
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Milestone
5.2.0

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 5, 2019

AuthenticationServiceException is reserved for internal errors, but sometimes the problem might be with the creds provided (and thus not an internal error).

It would be better to throw a Saml2AuthenticationException. Such an exception does not yet exist, but it seems a pretty handy exception to have.
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 5, 2019
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules labels Sep 5, 2019
@fhanik fhanik self-assigned this Sep 24, 2019
@fhanik fhanik closed this as completed in d472e99 Sep 24, 2019
fhanik added a commit to fhanik/spring-security that referenced this issue Sep 27, 2019
@fhanik
SAML Assertion validation should propagate errors: spring-projects#7375…
22da2b4 
… and spring-projects#7375

Fixes spring-projectsgh-7377
Fixes spring-projectsgh-7375

spring-projects#7377
spring-projects#7375

Clean up code

- Authentication request factory should only throw Saml2Exception
- OpenSamlImplementation should only throw Saml2Exception
- Move the OpenSamlImplementation package private methods to the right
section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
2 participants
@fhanik @jzheaux