Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ServletOAuth2AuthorizedClientExchangeFilterFunction is non-blocking #6589

Closed
3 tasks done
jgrandja opened this issue Mar 4, 2019 · 0 comments
Closed
3 tasks done

Ensure ServletOAuth2AuthorizedClientExchangeFilterFunction is non-blocking #6589

jgrandja opened this issue Mar 4, 2019 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.2.0.M4

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Mar 4, 2019 •
edited
Loading

As a result of #6483 and it's associated commit 091cbe5, we need to ensure that ServletOAuth2AuthorizedClientExchangeFilterFunction does not block on reactive threads.

This tool will likely help with the investigation - https://github.com/reactor/BlockHound

Tasks

  • Investigate and confirm blocking
  • #50 - Fix blocking in ServletOAuth2AuthorizedClientExchangeFilterFunction
  • #58 - Ensure non-blocking with OAuth2AccessTokenResponseBodyExtractor
@jgrandja jgrandja self-assigned this Mar 4, 2019
@jgrandja jgrandja added investigating in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Mar 4, 2019
@jgrandja jgrandja added this to the 5.2.0.M2 milestone Mar 4, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M3, 5.2.x May 21, 2019
@jgrandja jgrandja removed their assignment Jun 4, 2019
@jgrandja jgrandja modified the milestones: 5.2.x, 5.2.0.RC1 Jun 18, 2019
@jgrandja jgrandja self-assigned this Jun 18, 2019
@jgrandja jgrandja added the type: bug A general bug label Jun 21, 2019
@jgrandja jgrandja mentioned this issue Jun 25, 2019
Closed
jgrandja added a commit to jgrandja/spring-security that referenced this issue Jul 25, 2019
@jgrandja
Fix blocking in ServletOAuth2AuthorizedClientExchangeFilterFunction
70df9b5 
Fixes spring-projectsgh-6589
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Jul 26, 2019
Closed
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
@jgrandja @kostya05983
Fix blocking in ServletOAuth2AuthorizedClientExchangeFilterFunction
1c49991 
Fixes spring-projectsgh-6589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.2.0.M4
Development

Successfully merging a pull request may close this issue.

Fix blocking in ServletOAuth2AuthorizedClientExchangeFilterFunction jgrandja/spring-security
3 participants
@rwinch @jgrandja @spring-projects-issues