Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Servlet Spec 2.5 Support for HttpSessionSecurityContextRepository #6261

Closed
jzheaux opened this issue Dec 7, 2018 · 2 comments · Fixed by #6289
Closed

Remove Servlet Spec 2.5 Support for HttpSessionSecurityContextRepository #6261

jzheaux opened this issue Dec 7, 2018 · 2 comments · Fixed by #6289
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone
5.2.0.M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 7, 2018 •
edited
Loading

Related to #6220

HttpSessionSecurityContextRepository adds a request wrapper for supporting Servlet Spec 3's startAsync methods.

Because Spring Framework 5.x has moved its baseline to Servlet Spec 3.1, the code should always use this wrapper instead of checking the servlet spec version first.

Also, the Servlet 2.5 tests for this feature should be removed.
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 7, 2018
@jzheaux jzheaux added this to the 5.2.0.M1 milestone Dec 7, 2018
@jzheaux jzheaux mentioned this issue Dec 7, 2018
Closed
7 tasks
@dongmyo
Copy link
Contributor

dongmyo commented Dec 15, 2018

@jzheaux I'd like to take it

dongmyo added a commit to dongmyo/spring-security-1 that referenced this issue Dec 15, 2018
@dongmyo
Remove Servlet Spec 2.5 Support for HttpSessionSecurityContextRepository
d09012f 
Fixes: spring-projectsgh-6261
@dongmyo dongmyo mentioned this issue Dec 15, 2018
Merged
@jzheaux
Copy link
Contributor Author

jzheaux commented Dec 16, 2018

Thanks, @dongmyo! It's yours.

jzheaux pushed a commit that referenced this issue Dec 17, 2018
@dongmyo @jzheaux
Remove Servlet Spec 2.5 Support for HttpSessionSecurityContextRepository
3230cd6 
Fixes: gh-6261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

Successfully merging a pull request may close this issue.

Remove Servlet Spec 2.5 Support for HttpSessionSecurityContextRepository dongmyo/spring-security-1
2 participants
@dongmyo @jzheaux