Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubjectDnX509PrincipalExtractor is documented with incorrect regular expression #5770

Closed
sunflower-seed opened this issue Sep 4, 2018 · 4 comments
Closed

SubjectDnX509PrincipalExtractor is documented with incorrect regular expression #5770

sunflower-seed opened this issue Sep 4, 2018 · 4 comments
Assignees
@rwinch
Labels
in: docs An issue in Documentation or samples type: bug A general bug
Milestone
5.1.2

Comments

@sunflower-seed
Copy link
Contributor

https://github.com/spring-projects/spring-security/blob/master/web/src/main/java/org/springframework/security/web/authentication/preauth/x509/SubjectDnX509PrincipalExtractor.java#L39

In the source from above and also in the documentation this example is mentioned:

emailAddress=(.?),

I believe this wont work, because an valid E-Mail consists of more than one character.

I propose to change it to

emailAddress=(.*?),

which works in my use case.
@rwinch rwinch changed the title Not working matcher Example SubjectDnX509PrincipalExtractor is documented with incorrect regular expression Sep 5, 2018
@rwinch
Copy link
Member

rwinch commented Sep 5, 2018

@sunflower-seed Thanks for the report! Would you be interested in submitting a PR to fix this?

@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label Sep 5, 2018
@sunflower-seed
Copy link
Contributor Author

I'll have a look at it. May take some time.

@sunflower-seed sunflower-seed mentioned this issue Oct 17, 2018
Merged
@sunflower-seed
Copy link
Contributor Author

Hopefully catched all occurencies and hopefully did all github !@!/$ right....

#5988

@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Oct 17, 2018
@rwinch rwinch self-assigned this Oct 17, 2018
@rwinch rwinch added this to the 5.1.2 milestone Oct 17, 2018
@rwinch rwinch added status: duplicate A duplicate of another issue in: docs An issue in Documentation or samples type: bug A general bug labels Oct 17, 2018
@rwinch rwinch modified the milestones: 5.1.2, 5.2.0.M1 Oct 17, 2018
@rwinch
Copy link
Member

rwinch commented Oct 17, 2018 •
edited
Loading

Thanks for the PR I merged your PR (#5770) and this is fixed in master and 5.1.x via 03a3a3b

@rwinch rwinch closed this as completed Oct 17, 2018
@rwinch rwinch modified the milestones: 5.2.0.M1, 5.1.2 Oct 17, 2018
@rwinch rwinch removed the status: duplicate A duplicate of another issue label Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
5.1.2
Development

No branches or pull requests
2 participants
@rwinch @sunflower-seed