Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpSessionOAuth2AuthorizationRequestRepository handle multiple OAuth2AuthorizationRequest per session #5110

Closed
jgrandja opened this issue Mar 13, 2018 · 0 comments
Closed

HttpSessionOAuth2AuthorizationRequestRepository handle multiple OAuth2AuthorizationRequest per session #5110

jgrandja opened this issue Mar 13, 2018 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.1.0.M1

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Mar 13, 2018 •
edited
Loading

The current implementation of HttpSessionOAuth2AuthorizationRequestRepository should be capable of saving multiple OAuth2AuthorizationRequest's for a particular HttpSession.

There may be a scenario where a user triggers an Authorization Request for more than one client at a time (in subsequent steps).
@jgrandja jgrandja added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Mar 13, 2018
@jgrandja jgrandja added this to the 5.1.0.M1 milestone Mar 13, 2018
@jgrandja jgrandja self-assigned this Mar 13, 2018
@jgrandja jgrandja added type: enhancement A general enhancement and removed type: bug A general bug labels Mar 13, 2018
@jgrandja jgrandja mentioned this issue Mar 13, 2018
Closed
jgrandja added a commit to jgrandja/spring-security that referenced this issue Mar 19, 2018
@jgrandja
HttpSessionOAuth2AuthorizationRequestRepository handle multiple OAuth…
ee57e71 
…2AuthorizationRequest per session

Fixes spring-projectsgh-5110
@rwinch rwinch closed this as completed in 59cef7d Mar 21, 2018
@candrews candrews mentioned this issue Apr 16, 2021
Closed
candrews added a commit to candrews/spring-security that referenced this issue May 10, 2021
@candrews
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
ba5157a 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes spring-projectsgh-5145
Intentionally regresses spring-projectsgh-5110
rwinch pushed a commit that referenced this issue May 12, 2021
@candrews @rwinch
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
35f5ebd 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes gh-5145
Intentionally regresses gh-5110
jgrandja pushed a commit that referenced this issue May 13, 2021
@candrews @jgrandja
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
e447a35 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes gh-5145
Intentionally regresses gh-5110
jgrandja pushed a commit that referenced this issue May 14, 2021
@candrews @jgrandja
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
b8eee20 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes gh-5145
Intentionally regresses gh-5110
jgrandja pushed a commit that referenced this issue May 14, 2021
@candrews @jgrandja
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
ecb4a57 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes gh-5145
Intentionally regresses gh-5110
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@candrews
HttpSessionOAuth2AuthorizationRequestRepository: store one request by…
2a73432 
… default

Add setAllowMultipleAuthorizationRequests allowing applications to
revert to the previous functionality should they need to do so.

Closes spring-projectsgh-5145
Intentionally regresses spring-projectsgh-5110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.1.0.M1
Development

No branches or pull requests
1 participant
@jgrandja