Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ProviderJwtDecoderRegistry #4581

Closed
jgrandja opened this issue Sep 27, 2017 · 0 comments
Closed

Remove ProviderJwtDecoderRegistry #4581

jgrandja opened this issue Sep 27, 2017 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone
5.0.0.M5

Comments

@jgrandja
Copy link
Contributor

ProviderJwtDecoderRegistry should be removed as it's redundant.

Instead of the implementation DefaultProviderJwtDecoderRegistry that provides the association of Map<ProviderMetadata, JwtDecoder>, we can associate as Map<ClientRegistration, JwtDecoder>.

This would allow us to remove ProviderJwtDecoderRegistry, DefaultProviderJwtDecoderRegistry, ProviderMetadata and DefaultProviderMetadata
@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Sep 27, 2017
@jgrandja jgrandja added this to the 5.0.0.M5 milestone Sep 27, 2017
@jgrandja jgrandja self-assigned this Sep 27, 2017
This was referenced Sep 27, 2017
Closed
Closed
thomasdarimont pushed a commit to thomasdarimont/spring-security that referenced this issue Apr 25, 2018
@jgrandja @thomasdarimont
Remove ProviderJwtDecoderRegistry
8fe9da6 
Fixes spring-projectsgh-4581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Milestone
5.0.0.M5
Development

No branches or pull requests
1 participant
@jgrandja