Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizationCodeAuthenticationProcessingFilter -> favor query request matching #4576

Closed
jgrandja opened this issue Sep 26, 2017 · 0 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Sep 26, 2017

The current RequestMatcher for AuthorizationCodeAuthenticationProcessingFilter uses path matching, for example: /oauth2/authorize/code/{clientAlias}

It might make more sense to use query parameter matching instead. This would potentially allow the user to reuse the redirect-uri for 2 or more ClientRegistration configured with the same clientId.

GitHub only supports setting 1 redirect-uri per client. With the current setup this poses an issue when configuring 2 or more GitHub ClientRegistration's with the same clientId

@jgrandja jgrandja self-assigned this Sep 26, 2017
@jgrandja jgrandja added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Sep 26, 2017
@jgrandja jgrandja added this to the 5.0.0.M5 milestone Sep 26, 2017
@jgrandja jgrandja mentioned this issue Sep 26, 2017
28 tasks
thomasdarimont pushed a commit to thomasdarimont/spring-security that referenced this issue Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Development

No branches or pull requests

1 participant