Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write Spring Security documentation #2567

Closed
spring-projects-issues opened this issue Oct 15, 2013 · 3 comments
Closed

Re-write Spring Security documentation #2567

spring-projects-issues opened this issue Oct 15, 2013 · 3 comments
Labels
Epic in: docs An issue in Documentation or samples type: enhancement A general enhancement type: jira An issue that was migrated from JIRA

Comments

@spring-projects-issues
Copy link

spring-projects-issues commented Oct 15, 2013

We should rewrite the Spring Security documentation.

@spring-projects-issues
Copy link
Author

Stefan Haberl said:

There's a small documentation error in the latest CSRF section (http://docs.spring.io/spring-security/site/docs/3.2.x-SNAPSHOT/reference/html/csrf.html) concerning Multipart upload (13.5.4):

"The first option is to ensure that the MultipartFilter is specified before the Spring Security filter. Specifying the MultipartFilter after the Spring Security filter means that there is no authorization for invoking the MultipartFilter which means anyone can place temporary files on your server."

should probably read

"The first option is to ensure that the MultipartFilter is specified before the Spring Security filter. Specifying the MultipartFilter before the Spring Security filter means that there is no authorization for invoking the MultipartFilter which means anyone can place temporary files on your server."

@spring-projects-issues
Copy link
Author

Rob Winch said:

Thanks birnbuazn. Since this is a bug in the existing documentation and not related to the rewrite, I created SEC-2378 to address it.

@spring-projects-issues spring-projects-issues added in: docs An issue in Documentation or samples Open type: jira An issue that was migrated from JIRA labels Feb 5, 2016
@spring-projects-issues spring-projects-issues added this to the 4.0 Backlog milestone Feb 5, 2016
@rwinch rwinch modified the milestone: 4.0 Backlog Aug 15, 2016
@rwinch rwinch self-assigned this Mar 9, 2018
@rwinch rwinch added this to the 5.1.0.RC1 milestone Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
rwinch added a commit that referenced this issue Mar 9, 2018
@rwinch rwinch modified the milestones: 5.1.0.M2, 5.1.0.RC1 Jul 26, 2018
@rwinch rwinch added this to the 5.2.x milestone Oct 23, 2018
@rwinch rwinch modified the milestones: 5.2.x, 5.2.0.M1 Oct 29, 2018
fhanik added a commit that referenced this issue Feb 28, 2019
2019-02-27 Merge of master branch (update of docs) into doc rewrite
branch
fhanik added a commit to fhanik/spring-security that referenced this issue Mar 5, 2019
fhanik added a commit to fhanik/spring-security that referenced this issue Mar 5, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@rwinch rwinch modified the milestones: 5.2.0.M3, 5.2.x May 1, 2019
@rwinch rwinch added type: enhancement A general enhancement and removed Open labels May 3, 2019
@rwinch rwinch removed their assignment Jul 29, 2019
fhanik added a commit to fhanik/spring-security that referenced this issue Sep 19, 2019
jzheaux added a commit that referenced this issue Sep 30, 2019
Issue gh-2567

Co-authored-by: Jay Bryant <jbryant@pivotal.io>
Co-authored-by: Rob Winch <rwinch@users.noreply.github.com>
jzheaux added a commit that referenced this issue Sep 30, 2019
Issue gh-2567

Co-authored-by: Jay Bryant <jbryant@pivotal.io>
Co-authored-by: Rob Winch <rwinch@users.noreply.github.com>
jzheaux added a commit that referenced this issue Sep 30, 2019
rwinch added a commit that referenced this issue Oct 24, 2019
This better aligns with other documentation

Issue gh-2567
rwinch added a commit that referenced this issue Oct 24, 2019
rwinch added a commit that referenced this issue Oct 24, 2019
@rwinch rwinch closed this as completed in bbda755 Oct 24, 2019
rwinch added a commit that referenced this issue Oct 24, 2019
rwinch added a commit that referenced this issue Oct 28, 2019
@rwinch rwinch added the Epic label Nov 6, 2019
@rwinch rwinch reopened this Nov 6, 2019
@rwinch rwinch changed the title SEC-2363: Re-write Spring Security documentation Re-write Spring Security documentation Nov 6, 2019
@rwinch rwinch removed this from the 5.2.x milestone May 31, 2022
@marcusdacoregio
Copy link
Contributor

I'll close this because it seems that the title is misleading and the problem was solved on another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic in: docs An issue in Documentation or samples type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

4 participants