Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update io.r2dbc:r2dbc-h2 to 1.0.0.RC1 #11479

Closed
sjohnr opened this issue Jul 11, 2022 · 1 comment
Closed

Update io.r2dbc:r2dbc-h2 to 1.0.0.RC1 #11479

sjohnr opened this issue Jul 11, 2022 · 1 comment
Assignees
@marcusdacoregio
Labels
type: dependency-upgrade A dependency upgrade
Milestone
6.0.0-M6

Comments

@sjohnr
Copy link
Member

sjohnr commented Jul 11, 2022

Upgrade io.r2dbc:r2dbc-h2 (used as testImplementation in oauth2-client) to 1.0.0 once spring-r2dbc is compatible with the latest io.r2dbc artifacts.

Tests that are currently disabled and should be re-enabled:

  • org.springframework.security.oauth2.client.R2dbcReactiveOAuth2AuthorizedClientServiceTests
    • loadAuthorizedClientWhenExistsThenReturnAuthorizedClient()
    • saveAuthorizedClientWhenSaveThenLoadReturnsSaved()
    • saveAuthorizedClientWhenSaveClientWithExistingPrimaryKeyThenUpdate()
    • removeAuthorizedClientWhenExistsThenRemoved()
    • loadAuthorizedClientWhenExistsButNotFoundInClientRegistrationRepositoryThenThrowDataRetrievalFailureException()
@sjohnr sjohnr added the type: dependency-upgrade A dependency upgrade label Jul 11, 2022
@sjohnr sjohnr added this to the 6.0.x milestone Jul 11, 2022
sjohnr added a commit that referenced this issue Jul 11, 2022
@sjohnr
Disable failing tests until r2dbc-h2 is upgraded
614065b 
Issue gh-11479
@sjohnr
Copy link
Member Author

sjohnr commented Jul 11, 2022

Related spring-projects/spring-framework#28787

@marcusdacoregio marcusdacoregio self-assigned this Jul 13, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 6.0.x, 6.0.0-M6 Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

Labels
type: dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
2 participants
@sjohnr @marcusdacoregio