Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyInfo missing in AuthnRequest when using OpenSaml4AuthenticationRequestResolver #11354

Closed
chschu opened this issue Jun 8, 2022 · 1 comment
Closed

KeyInfo missing in AuthnRequest when using OpenSaml4AuthenticationRequestResolver #11354

chschu opened this issue Jun 8, 2022 · 1 comment
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
6.0.0-M6

Comments

@chschu
Copy link

chschu commented Jun 8, 2022

Describe the bug
When switching from the (deprecated) DefaultSaml2AuthenticationRequestContextResolver and OpenSaml4AuthenticationRequestFactory to OpenSaml4AuthenticationRequestResolver, the AuthnRequest's signature no longer contains a KeyInfo element.

To Reproduce

  • configure an OpenSaml4AuthenticationRequestResolver (e.g. by adding it as a Spring Bean)
  • configure an X.509 signing credential
  • start a SAML authentication

Expected behavior
The AuthnRequest signature contains a KeyInfo when using OpenSaml4AuthenticationRequestResolver.

Possible source: In org.springframework.security.saml2.provider.service.web.authentication.OpenSamlSigningUtils, no NamedKeyInfoGeneratorManager is configured in the SignatureSigningConfiguration. This is different from the two OpenSamlSigningUtils in other packages.
@chschu chschu added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Jun 8, 2022
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 9, 2022
@jzheaux jzheaux added this to the 6.0.0-M6 milestone Jun 9, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jun 9, 2022

Thanks, @chschu, for the report. We will prioritize getting this into the next point release.

jzheaux added a commit that referenced this issue Jun 9, 2022
@jzheaux
Add OpenSamlSigningUtilsTests
3a41567 
Issue gh-11354
@jzheaux jzheaux closed this as completed in 89fb075 Jun 9, 2022
jzheaux added a commit that referenced this issue Jun 9, 2022
@jzheaux
Add OpenSamlSigningUtilsTests
bb9c7d1 
Issue gh-11354
jzheaux added a commit that referenced this issue Jun 9, 2022
@jzheaux
Add missing KeyInfo
812bb0e 
Closes gh-11354
jzheaux added a commit that referenced this issue Jun 9, 2022
@jzheaux
Add OpenSamlSigningUtilsTests
bd60a0f 
Issue gh-11354
jzheaux added a commit that referenced this issue Jun 9, 2022
@jzheaux
Add missing KeyInfo
d22277c 
Closes gh-11354
@github-actions github-actions bot added the status: backported An issue that has been backported to maintenance branches label Jun 9, 2022
@github-actions github-actions bot mentioned this issue Jun 9, 2022
Closed
@rcwinder rcwinder mentioned this issue Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
6.0.0-M6
Development

No branches or pull requests
2 participants
@chschu @jzheaux