Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasIpAddress to Kotlin DSL #10577

Closed
sjohnr opened this issue Dec 1, 2021 · 4 comments · Fixed by #14133
Closed

Add hasIpAddress to Kotlin DSL #10577

sjohnr opened this issue Dec 1, 2021 · 4 comments · Fixed by #14133
Assignees
@brunodmartins
Labels
in: config An issue in spring-security-config status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@sjohnr
Copy link
Member

sjohnr commented Dec 1, 2021

This issue adds support for hasIpAddress in the Kotlin DSL.

Related #10571
@sjohnr sjohnr added in: config An issue in spring-security-config type: enhancement A general enhancement labels Dec 1, 2021
@sjohnr sjohnr self-assigned this Dec 1, 2021
@sjohnr sjohnr removed their assignment Jun 10, 2022
@sjohnr sjohnr added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jun 10, 2022
@atrifyllis
Copy link

#10571 is closed, why is this open?

@sjohnr
Copy link
Member Author

sjohnr commented Jan 17, 2023

@atrifyllis this is for the non-reactive DSL.

@brunodmartins
Copy link
Contributor

@sjohnr @atrifyllis I want to work on this issue!

@sjohnr
Copy link
Member Author

sjohnr commented Nov 13, 2023

It's yours @brunodmartins!

@brunodmartins brunodmartins mentioned this issue Nov 13, 2023
Merged
brunodmartins added a commit to brunodmartins/spring-security that referenced this issue Dec 8, 2023
@brunodmartins
Add hasIpAddress to Kotlin DSL
7f8aaf2 
Closes spring-projectsgh-10577
jzheaux added a commit to brunodmartins/spring-security that referenced this issue Dec 8, 2023
@jzheaux
Polish IpAddressAuthorizationManager
46b1ed9 
Closes spring-projectsgh-10577
jzheaux pushed a commit that referenced this issue Dec 15, 2023
@brunodmartins @jzheaux
Add hasIpAddress to Kotlin DSL
ea7c720 
Closes gh-10577
jzheaux added a commit that referenced this issue Dec 15, 2023
@jzheaux
Polish IpAddressAuthorizationManager
8a34e32 
Closes gh-10577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brunodmartins brunodmartins

Labels
in: config An issue in spring-security-config status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding DSL for hasIpAddress for WebMvc brunodmartins/spring-security
3 participants
@atrifyllis @sjohnr @brunodmartins