Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close searchResults so LDAP context can close. #609

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Close searchResults so LDAP context can close. #609

merged 1 commit into from
Jan 18, 2022

Conversation

perry2of5
Copy link
Contributor

Close searchResults so LDAP context can close.

Fixes #489

@perry2of5
Copy link
Contributor Author

This is a duplicate of pull #549, except I have signed the contributor agreement so I believe this can be merged.

@perry2of5
Copy link
Contributor Author

Should I attempt to close the searchResults inside the initial try?

@jzheaux jzheaux merged commit b74bb96 into spring-projects:main Jan 18, 2022
@jzheaux
Copy link
Contributor

jzheaux commented Jan 18, 2022

Thanks, @perry2of5! This is now merged into main. I also added a small polish in c5ab1ac.

@jzheaux jzheaux self-assigned this Jan 18, 2022
@jzheaux jzheaux added in: core type: bug A general bug labels Jan 18, 2022
@jzheaux jzheaux added this to the 2.4.0-M2 milestone Jan 18, 2022
@jzheaux jzheaux mentioned this pull request Jan 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: core type: bug A general bug
Projects
None yet
Milestone
2.4.0-M2
Development

Successfully merging this pull request may close these issues.

LDAP connection not closed due to DefaultDirContextValidator
2 participants
@perry2of5 @jzheaux