Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALPS spec name is "descriptor" not "descriptors" #665

Closed
gregturn opened this issue Nov 6, 2017 · 0 comments
Closed

ALPS spec name is "descriptor" not "descriptors" #665

gregturn opened this issue Nov 6, 2017 · 0 comments
Milestone
0.25

Comments

@gregturn
Copy link
Contributor

gregturn commented Nov 6, 2017

ALPS serialization generates "descriptors", when the value in the spec is singular.

https://tools.ietf.org/html/draft-amundsen-richardson-foster-alps-01#section-2.2.3
@gregturn gregturn mentioned this issue Nov 6, 2017
Closed
gregturn added a commit that referenced this issue Nov 7, 2017
@gregturn
#665 - Fix ALPS format
52b26be 
According to the ALPS spec, it's "descriptor" not "descriptors", despite it depicting an array of potentially multiple values. Also fixed the ordering to match as closely as possible all the samples shown in the spec.
odrotbohm pushed a commit that referenced this issue Apr 18, 2018
@gregturn @odrotbohm
#665 - Fix ALPS format.
6c0197c 
According to the ALPS spec, it's "descriptor" not "descriptors", despite it depicting an array of potentially multiple values. Also fixed the ordering to match as closely as possible all the samples shown in the spec.

Original pull request: #666.
odrotbohm pushed a commit that referenced this issue Apr 18, 2018
@gregturn @odrotbohm
#665 - Fix ALPS format.
22bd76d 
According to the ALPS spec, it's "descriptor" not "descriptors", despite it depicting an array of potentially multiple values. Also fixed the ordering to match as closely as possible all the samples shown in the spec.

Original pull request: #666.
@odrotbohm odrotbohm added this to the 0.25 milestone Apr 18, 2018
odrotbohm added a commit that referenced this issue Jun 20, 2018
@odrotbohm
#665 - Make sure Alps API stays compatible.
1618103 
Tweaked the changes made to Alps and Descriptor builders so that they only affect the representation rendered by Jackson, not the actual API.
odrotbohm added a commit that referenced this issue Jun 20, 2018
@odrotbohm
#665 - Make sure Alps API stays compatible.
a7708bb 
Tweaked the changes made to Alps and Descriptor builders so that they only affect the representation rendered by Jackson, not the actual API.
odrotbohm added a commit to spring-projects/spring-data-rest that referenced this issue Jun 20, 2018
@odrotbohm
DATAREST-1256 - Upgraded to Spring HATEOAS 0.25.0.BUILD-SNAPSHOT.
6ee2b13 
Adapted RepositoryRestMvcConfiguration to now create a shared fallback ObjectMapper and avoid to register it as Spring Bean. Adapted test cases that previously were relying on such a bean being present.

Adapted test cases to verify on the correct ALPS document structure (see spring-projects/spring-hateoas#665).
odrotbohm added a commit to spring-projects/spring-data-rest that referenced this issue Jun 20, 2018
@odrotbohm
DATAREST-1256 - Upgraded to Spring HATEOAS 0.25.0.BUILD-SNAPSHOT.
7212946 
Adapted RepositoryRestMvcConfiguration to now create a shared fallback ObjectMapper and avoid to register it as Spring Bean. Adapted test cases that previously were relying on such a bean being present.

Adapted test cases to verify on the correct ALPS document structure (see spring-projects/spring-hateoas#665).
odrotbohm added a commit to spring-projects/spring-data-rest that referenced this issue Jul 2, 2018
@odrotbohm
DATAREST-1256 - Upgraded to Spring HATEOAS 0.25.0.BUILD-SNAPSHOT.
d669ddc 
Adapted RepositoryRestMvcConfiguration to now create a shared fallback ObjectMapper and avoid to register it as Spring Bean. Adapted test cases that previously were relying on such a bean being present.

Adapted test cases to verify on the correct ALPS document structure (see spring-projects/spring-hateoas#665).
odrotbohm added a commit to spring-projects/spring-data-rest that referenced this issue Jul 2, 2018
@odrotbohm
DATAREST-1256 - Upgraded to Spring HATEOAS 0.25.0.BUILD-SNAPSHOT.
954416a 
Adapted RepositoryRestMvcConfiguration to now create a shared fallback ObjectMapper and avoid to register it as Spring Bean. Adapted test cases that previously were relying on such a bean being present.

Adapted test cases to verify on the correct ALPS document structure (see spring-projects/spring-hateoas#665).
gregturn pushed a commit that referenced this issue Jan 9, 2019
@odrotbohm @gregturn
#665 - Make sure Alps API stays compatible.
fcc26eb 
Tweaked the changes made to Alps and Descriptor builders so that they only affect the representation rendered by Jackson, not the actual API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25
Development

No branches or pull requests
2 participants
@odrotbohm @gregturn