Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spring MVC Security Sample #58

Closed
rstoyanchev opened this issue Jun 17, 2021 · 0 comments
Closed

Add Spring MVC Security Sample #58

rstoyanchev opened this issue Jun 17, 2021 · 0 comments
Assignees
@rwinch
Labels
in: security Issues related to security type: enhancement A general enhancement
Milestone
1.0.0-M1

Comments

@rstoyanchev
Copy link
Contributor

There is already a sample that demonstrates use of Spring Security on WebFlux. We need another for Spring MVC.
@rstoyanchev rstoyanchev added type: enhancement A general enhancement in: security Issues related to security labels Jun 17, 2021
@rstoyanchev rstoyanchev added this to the 1.0 M1 milestone Jun 17, 2021
rstoyanchev added a commit that referenced this issue Jun 24, 2021
@rstoyanchev
Improve ThreadLocal value handling
ab99dc2 
ThreadLocal values from a Servlet container thread maybe end up being
unnecessarily restored, e.g. if DataFetcher is invoked on the same
thread and then also removed, which then impacts the filter chain.

The ContextManager now saves the thread id when values are extracted
and ignores restore or remove calls if still on the same thread. This
should also be more optimal, avoiding ThreadLocal access if threads
aren't switched.

See gh-58
@rwinch rwinch closed this as completed in 7d854db Jun 28, 2021
rwinch added a commit that referenced this issue Jun 28, 2021
@rwinch
webmvc-http-security uses WebGraphQlTester
dfebb6f 
Issue gh-58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: security Issues related to security type: enhancement A general enhancement
Projects
None yet
Milestone
1.0.0-M1
Development

No branches or pull requests
2 participants
@rwinch @rstoyanchev