Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve configuration and defaults for document location #338

Closed
rstoyanchev opened this issue Mar 24, 2022 · 0 comments
Closed

Improve configuration and defaults for document location #338

rstoyanchev opened this issue Mar 24, 2022 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Mar 24, 2022

Currently, "classpath:graphql" is the default location for server schema files and for ".graphql" document files for GraphQlClient and GraphQlTester, which leads to issues like #308 where "graphql" under src/test (for documents to test the server with) overshadows the same location with the schema files under src/main.

We need to refine this a bit as follows:

  • The server remains with the current default "graphql" on the main classpath
  • The Tester can default to "graphql-test" (under src/test) for document files to test the server with
  • The Client can default to "graphql-documents" (under src/main), and we can expose an overloaded method on GraphQlClient.Builder to make it easy to have a different location for each remote server.
@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Mar 24, 2022
@rstoyanchev rstoyanchev added this to the 1.0.0-RC1 milestone Mar 24, 2022
@rstoyanchev rstoyanchev self-assigned this Mar 24, 2022
bclozel added a commit to spring-projects/spring-boot that referenced this issue Apr 4, 2022
After changes performed in spring-projects/spring-graphql#338, GraphQL
test documents now have a different test location.
bclozel added a commit to bclozel/sgql-streaming-issue that referenced this issue Aug 3, 2022
As of spring-projects/spring-graphql#338, the location for test
documents has changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant