Revise JSONPath options in GraphQlTester

[jord1e]

The existing methods do not cover this case. The valueIsEmpty and valueIsNotEmpty methods do way more checks.

[rstoyanchev]

I've made a small adjustment in 2095e17.

That aside, you can use pathExists().valueDoesNotExist() if you want to check both that the path is present and there is no value there, or otherwise valueDoesNotExist() if it's enough to check there isn't a value one, and possibly no such path at all.

Apart from trying to keep the combinations down, null is a tricky concept with a JSONPath which can be indefinite.

[spring-projects-issues]

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

[jord1e]

The concepts of absence and null are clearly separated in the spec: https://spec.graphql.org/draft/#sel-FAHlBFDCAACEMnwN

Fields are always optional within the context of a selection set, a field may be omitted and the selection set is still valid. However fields that return Non-Null types will never return the value null if queried.

It talks about "optional" fields (the absence of a field). and Non-Null/Null fields, aka "field is present but null"

These two states should both be assert-able separately

[rstoyanchev]

On further thought and review, I'm going to re-purpose this for a broader update of the available options. The current choice is confusing, with some options overlapping, valueExists and valueIsNotEmpty, while overall there are too many options and a lack of guidance.

As far as I can see, the following should suffice:

• hasValue - valid field, possibly partial but not null
• isNull - failed field, or optional field set to null
• doesNotExist - the path is not even present

Note, the isNull check can only apply to single value paths, e.g. books, books[1].title. Indefinite paths like book[*], book[?(@.category = 'fiction')] cannot be supported and will be rejected.

For anything beyond, there is toEntity and toEntityList.

[jord1e]

Sounds great, exactly what the issue was aimed at, thank you!