Remove a unnecessary else in DefaultSingletonBeanRegistry #33502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `getSingleton(String, ObjectFactory<?>)` may throw a `BeanCurrentlyInCreationException` in multiple threads. If Thread-A acquires the `singletonLock`, but before it assigns itself to `singletonCreationThread`, Thread-B gets a null value at `singletonCreationThread`, then Thread-A and Thread-B will both invoke `beforeSingletonCreation`. In this commit, I remove the else, so the thread which does not acquire `singletonLock` will be blocked at the code `this.singletonLock.lock()`. Closes gh-33463
|
@liuao1004 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@liuao1004 Thank you for signing the Contributor License Agreement! |
bclozel
added
the
in: core
The method `getSingleton(String, ObjectFactory<?>)` may throw a `BeanCurrentlyInCreationException` in multiple threads. If Thread-A acquires the `singletonLock`, and it assigns itself to `singletonCreationThread` immediately, Thread-B will get a not null value at `singletonCreationThread`, then Thread-A and Thread-B will both invoke `beforeSingletonCreation`. In this commit, I remove the else, so the thread which does not acquire `singletonLock` will be blocked at the code `this.singletonLock.lock()`. Closes gh-33463
|
That |
jhoeller
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
getSingleton(String, ObjectFactory<?>)may throw aBeanCurrentlyInCreationExceptionin multiple threads.If Thread-A acquires the
singletonLock, but before it assigns itself tosingletonCreationThread,Thread-B gets a null value at
singletonCreationThread, then Thread-A and Thread-B will both invokebeforeSingletonCreation.In this commit, I remove the else,
so the thread which does not acquire
singletonLockwill be blocked at the codethis.singletonLock.lock().Closes gh-33463