Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for publishing test execution life-cycle events #22477

Closed
wants to merge 1 commit into from
Closed

Provide support for publishing test execution life-cycle events #22477

wants to merge 1 commit into from

Conversation

maverick1601
Copy link
Contributor

Adds new TestExecutionListener for publishing events to the test application context.
These may be consumed by @eventlistener annotated methods to react to the test
life-cycle. The test execution listener isn't enabled by default.

Implements #18490

@pivotal-issuemaster
Copy link

@maverick1601 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@maverick1601 Thank you for signing the Contributor License Agreement!

@maverick1601 maverick1601 mentioned this pull request Feb 26, 2019
Closed
5 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 26, 2019
@sbrannen sbrannen self-assigned this Feb 27, 2019
@sbrannen sbrannen added in: test Issues in the test module type: enhancement A general enhancement labels Feb 27, 2019
@sbrannen sbrannen added this to the 5.2 M1 milestone Feb 27, 2019
@sbrannen
Copy link
Member

I noticed there are some code quality violations.

Would you mind addressing those in your PR?

@maverick1601
Copy link
Contributor Author

I will fix those

@sbrannen sbrannen removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 27, 2019
@maverick1601
Copy link
Contributor Author

maverick1601 commented Feb 27, 2019 •
edited
Loading

Seems like most of them are fixed. There is one violation, because the dummyTestMethod() used in the integration test needs documentation. But for me this is a false positive.

@sbrannen
Copy link
Member

Seems like most of them are fixed.

Thanks

sbrannen
sbrannen requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Please make the requested changes, and I'll then make a final review.

Cheers,

Sam

spring-test/src/main/java/org/springframework/test/context/TestExecutionListener.java Outdated Show resolved Hide resolved
...-test/src/main/java/org/springframework/test/context/event/AfterClassTestExecutionEvent.java Outdated Show resolved Hide resolved
...-test/src/main/java/org/springframework/test/context/event/AfterClassTestExecutionEvent.java Outdated Show resolved Hide resolved
spring-test/src/main/java/org/springframework/test/context/event/package-info.java Outdated Show resolved Hide resolved
.../springframework/test/context/event/EventPublishingTestExecutionListenerIntegrationTest.java Outdated Show resolved Hide resolved
.../springframework/test/context/event/EventPublishingTestExecutionListenerIntegrationTest.java Outdated Show resolved Hide resolved
spring-test/src/main/java/org/springframework/test/context/event/annotation/AfterTestClass.java Outdated Show resolved Hide resolved
...st/java/org/springframework/test/context/event/EventPublishingTestExecutionListenerTest.java Outdated Show resolved Hide resolved
.../springframework/test/context/event/EventPublishingTestExecutionListenerIntegrationTest.java Outdated Show resolved Hide resolved
...st/java/org/springframework/test/context/event/EventPublishingTestExecutionListenerTest.java Outdated Show resolved Hide resolved
@maverick1601
Copy link
Contributor Author

Resolved all review tasks, hopefully.

@sbrannen
Copy link
Member

Resolved all review tasks, hopefully.

Yep. Looks good. I think the only thing you missed is the copyright date for the test classes, but that's not a big deal. 😉

Thanks for making the changes!

@maverick1601
Provide support for publishing test execution life-cycle events
e9b63ce 
Adds new TestExecutionListener for publishing events to the test application context.
These may be consumed by @eventlistener annotated methods to react to the test
life-cycle. The test execution listener isn't enabled by default.

Implements spring-projects#18490
@maverick1601
Copy link
Contributor Author

maverick1601 commented Feb 28, 2019 •
edited
Loading

Fixed the test class copyrights, as well. These were all due to the cherry-pick from 2016 ;-)

@sbrannen
Copy link
Member

Thanks for all of the hard work, @maverick1601.

I'll see if I can merge this in the coming days.

@sbrannen
Copy link
Member

sbrannen commented Mar 1, 2019

This work has been merged into master in 34fee86 and refined in 2d6624d.

@sbrannen sbrannen closed this Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels
in: test Issues in the test module type: enhancement A general enhancement
Projects
None yet
Milestone
5.2 M1
Development

Successfully merging this pull request may close these issues.
4 participants
@maverick1601 @pivotal-issuemaster @sbrannen @spring-projects-issues