SpEL cannot invoke varargs MethodHandle function with an array
#33191
Assignees
Labels
Milestone
Comments
sbrannen
added
type: bug
sbrannen
changed the title
MethodHandle function with an array
sbrannen
added a commit
that referenced
this issue
Jul 12, 2024
Prior to this commit, the Spring Expression Language (SpEL) could not invoke a varargs MethodHandle function with a primitive array containing the variable arguments, although that is supported for a varargs Method function. Attempting to do so resulted in the first element of the primitive array being supplied as a single argument to the MethodHandle, effectively ignoring any variable arguments after the first one. This commit addresses this by updating the convertAllMethodHandleArguments(...) method in ReflectionHelper as follows when the user supplies the varargs already packaged in a primitive array. - Regarding conversion, use the wrapper type for a primitive varargs array, since we eventually need an Object array in order to invoke the MethodHandle in FunctionReference#executeFunctionViaMethodHandle(). - When deciding whether to convert a single element passed as varargs, we now check if the argument is an array that is assignable to the varargs array type. - When converting an array supplied as the varargs, we now convert that array to the varargs array type instead of the varargs component type. Note, however, that a SpEL expression cannot provide a primitive array for an Object[] varargs target. This is due to the fact that the ArrayToArrayConverter used by Spring's ConversionService does not support conversion from a primitive array to Object[] -- for example, from int[] to Object[]. See gh-33191 Closes gh-33198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Spring Expression Language (SpEL) currently cannot invoke a varargs
MethodHandlefunction with an array, although that is supported for a varargsMethodfunction.Attempting to do so results in the array being supplied as a single argument to the
MethodHandle.For example, given a
MethodHandleregistered as a function namedformatthat accepts(String, Object...), the SpEL expression#format('x', 'a', 'z')is supported, but the expression#format('x', new Object[]{'a', 'z'})fails to evaluate since theMethodHandleis invoked with('x', ['a', 'z'])whereas('x', 'a', 'z')is required for aMethodHandleinvocation.The text was updated successfully, but these errors were encountered: