Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document instrumentation for RestTemplate and/or WebClient #29904

Closed
oppegard opened this issue Jan 30, 2023 · 1 comment
Closed

Document instrumentation for RestTemplate and/or WebClient #29904

oppegard opened this issue Jan 30, 2023 · 1 comment
Assignees
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: documentation A documentation task
Milestone

Comments

@oppegard
Copy link

Affects: 6.0.x


The following callout was written in the Spring Sleuth documentation for HTTP clients:

You have to register RestTemplate as a bean so that the interceptors get injected. If you create a RestTemplate instance with a new keyword, the instrumentation does NOT work.

I can't figure out if the same guidance applies in 6.0.x for Micrometer Tracing at either:

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Jan 30, 2023
@bclozel bclozel self-assigned this Jan 30, 2023
@sbrannen sbrannen added type: documentation A documentation task in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 31, 2023
@bclozel bclozel added theme: observability An issue related to observability and tracing and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 31, 2023
@bclozel bclozel added this to the 6.0.x milestone Jan 31, 2023
@bclozel bclozel changed the title Document instrumentation for RestTemplate and/or WebClient in 6.0.x Document instrumentation for RestTemplate and/or WebClient Feb 2, 2023
@bclozel bclozel modified the milestones: 6.0.x, 6.0.5 Feb 2, 2023
@bclozel bclozel closed this as completed in 7440afe Feb 2, 2023
@bclozel
Copy link
Member

bclozel commented Feb 2, 2023

I'll create a follow-up issue in Spring Boot to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) theme: observability An issue related to observability and tracing type: documentation A documentation task
Projects
None yet
Development

No branches or pull requests

4 participants