Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ConcurrentReferenceHashMap a bit more JIT friendly #22566

Closed
Tracked by #22560
philwebb opened this issue Mar 11, 2019 · 0 comments
Closed
Tracked by #22560

Make ConcurrentReferenceHashMap a bit more JIT friendly #22566

philwebb opened this issue Mar 11, 2019 · 0 comments
Assignees
@philwebb
Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Milestone
5.2 M1

Comments

@philwebb
Copy link
Member

We use ConcurrentReferenceHashMap for quite a few caches and JITWatch highlighted a few methods that are not that inline friendly. I'm not sure that it makes a big difference in practice, but we could refactor it a little.
@philwebb philwebb mentioned this issue Mar 11, 2019
Closed
23 tasks
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 11, 2019
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 12, 2019
@philwebb philwebb self-assigned this Mar 13, 2019
snicoll pushed a commit to snicoll/spring-framework that referenced this issue Mar 13, 2019
@philwebb @snicoll
Make ConcurrentReferenceHashMap more JIT friendly
e5cbb72 
Update `ConcurrentReferenceHashMap` to make some methods more inline
friendly, and to manually inline a few others. These minor optimizations
don't make a great deal of difference for most applications, but seem
worthwhile since we use `ConcurrentReferenceHashMap` for many internal
caches.

Closes spring-projectsgh-22566
philwebb added a commit to philwebb/spring-framework that referenced this issue Mar 14, 2019
@philwebb
Make ConcurrentReferenceHashMap more JIT friendly
d39ffcc 
Update `ConcurrentReferenceHashMap` to make some methods more inline
friendly, and to manually inline a few others. These minor optimizations
don't make a great deal of difference for most applications, but seem
worthwhile since we use `ConcurrentReferenceHashMap` for many internal
caches.

Closes spring-projectsgh-22566
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Mar 23, 2019
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: core Issues in core modules (aop, beans, core, context, expression)
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
4 participants
@sbrannen @philwebb @jhoeller @spring-projects-issues