Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate existing AnnotationUtils and AnnotatedElementUtils to use new MergedAnnotations API #22562

Closed
Tracked by #22560
philwebb opened this issue Mar 11, 2019 · 0 comments
Closed
Tracked by #22560

Migrate existing AnnotationUtils and AnnotatedElementUtils to use new MergedAnnotations API #22562

philwebb opened this issue Mar 11, 2019 · 0 comments
Assignees
@philwebb
Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Milestone
5.2 M1

Comments

@philwebb
Copy link
Member

Rather than having two different implementations for managing merged annotations, we should consider migrating our existing AnnotationUtils and AnnotatedElementUtils classes to the MergedAnnotations API being developed in #21697
@philwebb philwebb self-assigned this Mar 11, 2019
@philwebb philwebb added the type: task A general task label Mar 11, 2019
@philwebb philwebb mentioned this issue Mar 11, 2019
Closed
23 tasks
@sbrannen sbrannen added the in: core Issues in core modules (aop, beans, core, context, expression) label Mar 12, 2019
snicoll pushed a commit to snicoll/spring-framework that referenced this issue Mar 13, 2019
@philwebb @snicoll
Start migration annotation utility methods
5e434c2 
Create internal variants of the existing `AnnotationUtils` and
`AnnotatedElementUtils` classes and migrate the existing classes to
use them.

The internal variants will be used to check that the same results are
given as we migrate the utils methods to use the new `MergedAnnotations`
API.

See spring-projectsgh-22562
snicoll pushed a commit to snicoll/spring-framework that referenced this issue Mar 13, 2019
@philwebb @snicoll
Migrate and verify annotation utility methods
28f87af 
Migrate all possible `AnnotationUtils` and `AnnotatedElementUtils`
method to the `MergedAnnotation` API, verify results against the old
implementations.

All migrated methods now call both the new API and the old version and
ensure that the same results or exceptions are raised. A full build of
both Spring Framework and Spring Boot has been executed to ensure, as
much as possible, that the migration does not cause unexpected
regressions.

See spring-projectsgh-22562
snicoll pushed a commit to snicoll/spring-framework that referenced this issue Mar 13, 2019
@philwebb @snicoll
Complete migration of annotation utility methods
a44e08f 
Delete `InternalAnnotationUtils` and `InternalAnnotatedElementUtils` and
migrate exclusively to the new `MergedAnnotations` API.

Closes spring-projectsgh-22562
philwebb added a commit to philwebb/spring-framework that referenced this issue Mar 14, 2019
@philwebb
Start migration annotation utility methods
5316769 
Create internal variants of the existing `AnnotationUtils` and
`AnnotatedElementUtils` classes and migrate the existing classes to
use them.

The internal variants will be used to check that the same results are
given as we migrate the utils methods to use the new `MergedAnnotations`
API.

See spring-projectsgh-22562
philwebb added a commit to philwebb/spring-framework that referenced this issue Mar 14, 2019
@philwebb
Migrate and verify annotation utility methods
6a7e022 
Migrate all possible `AnnotationUtils` and `AnnotatedElementUtils`
method to the `MergedAnnotation` API, verify results against the old
implementations.

All migrated methods now call both the new API and the old version and
ensure that the same results or exceptions are raised. A full build of
both Spring Framework and Spring Boot has been executed to ensure, as
much as possible, that the migration does not cause unexpected
regressions.

See spring-projectsgh-22562
philwebb added a commit to philwebb/spring-framework that referenced this issue Mar 14, 2019
@philwebb
Complete migration of annotation utility methods
61cf1ea 
Delete `InternalAnnotationUtils` and `InternalAnnotatedElementUtils` and
migrate exclusively to the new `MergedAnnotations` API.

Closes spring-projectsgh-22562
jhoeller pushed a commit that referenced this issue Mar 23, 2019
@philwebb @jhoeller
Start migration annotation utility methods
b91ccf0 
Create internal variants of the existing `AnnotationUtils` and
`AnnotatedElementUtils` classes and migrate the existing classes to
use them.

The internal variants will be used to check that the same results are
given as we migrate the utils methods to use the new `MergedAnnotations`
API.

See gh-22562
jhoeller pushed a commit that referenced this issue Mar 23, 2019
@philwebb @jhoeller
Migrate and verify annotation utility methods
a14bfe9 
Migrate all possible `AnnotationUtils` and `AnnotatedElementUtils`
method to the `MergedAnnotation` API, verify results against the old
implementations.

All migrated methods now call both the new API and the old version and
ensure that the same results or exceptions are raised. A full build of
both Spring Framework and Spring Boot has been executed to ensure, as
much as possible, that the migration does not cause unexpected
regressions.

See gh-22562
@jhoeller jhoeller added this to the 5.2 M1 milestone Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philwebb philwebb

Labels
in: core Issues in core modules (aop, beans, core, context, expression) type: task A general task
Projects
None yet
Milestone
5.2 M1
Development

No branches or pull requests
3 participants
@sbrannen @philwebb @jhoeller