Add missing break statements to stop looping when result is known

Closes gh-22573
spring-projects · Mar 12, 2019 · a35adc6 · a35adc6
1 parent 96cd441
commit a35adc6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoTests.java b/spring-beans/src/test/java/org/springframework/beans/ExtendedBeanInfoTests.java
@@ -754,6 +754,7 @@ class ExtendedTestBean extends TestBean {
 		for (PropertyDescriptor pd : ebi.getPropertyDescriptors()) {
 			if (pd.getName().equals("foo")) {
 				found = true;
+				break;
 			}
 		}
 		assertThat(found, is(true));

diff --git a/...ng-context/src/main/java/org/springframework/scripting/support/StandardScriptFactory.java b/...ng-context/src/main/java/org/springframework/scripting/support/StandardScriptFactory.java
@@ -151,6 +151,7 @@ public Object getScriptedObject(ScriptSource scriptSource, @Nullable Class<?>...
 				if (script instanceof Class ? !requestedIfc.isAssignableFrom((Class<?>) script) :
 						!requestedIfc.isInstance(script)) {
 					adaptationRequired = true;
+					break;
 				}
 			}
 			if (adaptationRequired) {

diff --git a/...st/java/org/springframework/core/io/support/PathMatchingResourcePatternResolverTests.java b/...st/java/org/springframework/core/io/support/PathMatchingResourcePatternResolverTests.java
@@ -89,7 +89,7 @@ public void classpathStarWithPatternOnFileSystem() throws IOException {
 				noCloverResources.add(resource);
 			}
 		}
-		resources = noCloverResources.toArray(new Resource[noCloverResources.size()]);
+		resources = noCloverResources.toArray(new Resource[0]);
 		assertProtocolAndFilenames(resources, "file",
 				StringUtils.concatenateStringArrays(CLASSES_IN_CORE_IO_SUPPORT, TEST_CLASSES_IN_CORE_IO_SUPPORT));
 	}
@@ -113,6 +113,7 @@ public void rootPatternRetrievalInJarFiles() throws IOException {
 		for (Resource resource : resources) {
 			if (resource.getFilename().equals("aspectj_1_5_0.dtd")) {
 				found = true;
+				break;
 			}
 		}
 		assertTrue("Could not find aspectj_1_5_0.dtd in the root of the aspectjweaver jar", found);