Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when json-patch append adds primitive to collection o… #2247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreivn2
Copy link

Throw exception when json-patch append adds primitive to collection of complex objects

When trying to do an json-patch append to a collection of complex objects, if we provide a primitive such as a string for the value there is no type checking. This causes a type mismatched item to be added to the collection.

Main cause is that org.springframework.data.rest.webmvc.json.patch.JsonPatchPatchConverter#valueFromJsonNode returns JsonLateObjectEvaluator only for complex types. If a primitive value is returned from this method, the value is not checked by the PatchOperation class.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants