Skip to content

Polishing #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Polishing #3231

wants to merge 8 commits into from

Conversation

onobc
Copy link
Contributor

@onobc onobc commented Oct 7, 2025

This polishes the previous commits around new commands HGETDEL / HGETEX / HSETEX.

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

onobc added 8 commits October 6, 2025 10:19
@onobc
Polish "Add HGETDEL, HGETEX and HSETEX hash commands".
3f2995c 
This commit polishes the previous commit with the following:

- Convert space indents into tab indents

Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Reorder commands in LettuceConnection
3d2b787 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Remove magic UTF characters from LettuceConverters
38ade5f 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Remove invisible UTF characters from LettuceConverters
f73833c 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Add missing @since tags
090a479 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Add @see for new commands in interfaces
d6d7d24 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
- Replace Intellij @NotNull with Jspecify @NonNull
748e344 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc
Add unit tests for the new converter methods
424026b 
Signed-off-by: Chris Bono <chris.bono@broadcom.com>
@onobc onobc requested a review from mp911de October 7, 2025 21:15
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Oct 7, 2025
mp911de
mp911de reviewed Oct 8, 2025
View reviewed changes
src/test/java/org/springframework/data/redis/connection/jedis/JedisConvertersUnitTests.java
* Unit tests for {@link JedisConverters#toHGetExParams}.
*/
@Nested
class HGetExParamsTests { // GH-3211
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, we never got used to nested tests. Without having something tangible, it feels too verbose for too little value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onobc @mp911de @spring-projects-issues