Validate that at least one node is set when configuring static master/replica with Redis #47401
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NeatGuyCoding
commented
Oct 5, 2025
NeatGuyCoding
commented
- Fix a. minor typo
- Add morereadable description
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
snicoll
changed the title
snicoll
added
type: task
|
@NeatGuyCoding thanks for the PR. I think we should rather focus on the check for at least one node. I think I had done that elsewhere but it looks like I missed it. |
snicoll
pushed a commit
that referenced
this pull request
Oct 5, 2025
See gh-47401 Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
snicoll
pushed a commit
that referenced
this pull request
Oct 5, 2025
See gh-47401 Signed-off-by: NeatGuyCoding <15627489+NeatGuyCoding@users.noreply.github.com>
snicoll
added a commit
that referenced
this pull request
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.