Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish formatting of log configuration file #43322

Closed
wants to merge 1 commit into from
Closed

Polish formatting of log configuration file #43322

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 29, 2024 •
edited
Loading

  1. Remove space before /> to keep consistency.
  2. Capitalize filters for Log4j2.
  3. Uppercase log level to keep consistency.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 29, 2024
@quaff
Copy link
Contributor Author

quaff commented Nov 29, 2024

No sure which style is preferred by Spring Boot, but mixing different styles is not good.

@quaff quaff marked this pull request as draft November 29, 2024 07:36
@quaff quaff marked this pull request as ready for review November 29, 2024 07:45
@wilkinsona
Copy link
Member

Thanks, @quaff.

Remove space before /> to keep consistency.

The --format support in xmllint removes them so that feels like as good a reason as any to go in that direction.

Unwrap for Log4j2

I'm not sure we should do this. It's certainly more than a formatting change as it removes the use of the filters plugin. I think I'd prefer that this part of the changes is reverted.

@quaff
Polish formatting of log configuration file
13517fa 
1. Remove space before `/>` to keep consistency.
2. Capitalize `filters` for Log4j2.
3. Uppercase log level to keep consistency.
@quaff
Copy link
Contributor Author

quaff commented Nov 29, 2024

I think I'd prefer that this part of the changes is reverted.

Done, and capitalize filters.

@mhalbritter mhalbritter added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 2, 2024
@mhalbritter mhalbritter added this to the 3.3.x milestone Dec 2, 2024
@snicoll snicoll self-assigned this Dec 4, 2024
@snicoll snicoll modified the milestones: 3.3.x, 3.3.7 Dec 4, 2024
@snicoll snicoll mentioned this pull request Dec 4, 2024
Closed
snicoll pushed a commit that referenced this pull request Dec 4, 2024
@quaff @snicoll
Polish formatting of log configuration file
3f17e42 
1. Remove space before `/>` to keep consistency.
2. Capitalize `filters` for Log4j2.
3. Uppercase log level to keep consistency.

See gh-43322
snicoll added a commit that referenced this pull request Dec 4, 2024
@snicoll
Polish "Polish formatting of log configuration file"
cc274cc 
See gh-43322
@snicoll snicoll closed this in 3f346d4 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snicoll snicoll

Labels
type: task A general task
Projects
None yet
Milestone
3.3.7
Development

Successfully merging this pull request may close these issues.
5 participants
@quaff @wilkinsona @snicoll @spring-projects-issues @mhalbritter