Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace scope strings with constants #43065

Closed
wants to merge 1 commit into from
Closed

Replace scope strings with constants #43065

wants to merge 1 commit into from

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Nov 8, 2024 •
edited
Loading

And replace "session" with WebApplicationContext.SCOPE_SESSION

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 8, 2024
@quaff
Replace "prototype" with BeanDefinition.SCOPE_PROTOTYPE
f9df549 
And replace `"session"` with `WebApplicationContext.SCOPE_SESSION`
@mhalbritter mhalbritter added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 8, 2024
@mhalbritter mhalbritter added this to the 3.2.x milestone Nov 8, 2024
@mhalbritter mhalbritter changed the title Replace "prototype" with BeanDefinition.SCOPE_PROTOTYPE Replace scope strings with constants Nov 8, 2024
@wilkinsona wilkinsona self-assigned this Nov 8, 2024
@wilkinsona wilkinsona mentioned this pull request Nov 8, 2024
Closed
@wilkinsona wilkinsona modified the milestones: 3.2.x, 3.2.12 Nov 8, 2024
wilkinsona pushed a commit that referenced this pull request Nov 8, 2024
@quaff @wilkinsona
Use constants for well-known scope names
03841b1 
See gh-43065
wilkinsona added a commit that referenced this pull request Nov 8, 2024
@wilkinsona
Polish "Use constants for well-known scope names"
5d63335 
See gh-43065
@wilkinsona wilkinsona closed this in 90de82a Nov 8, 2024
@wilkinsona
Copy link
Member

Thanks, @quaff. As part of merging this, I switched from the constants on BeanDefinition to those on ConfigurableBeanFactory as the latter is what the javadoc of @Scope recommends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
type: task A general task
Projects
None yet
Milestone
3.2.12
Development

Successfully merging this pull request may close these issues.
4 participants
@quaff @wilkinsona @spring-projects-issues @mhalbritter