Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gradle plugin allows the use of Gradle 7.4 but the documented and tested minimum is 7.5 #39508

Closed
wants to merge 1 commit into from
Closed

Gradle plugin allows the use of Gradle 7.4 but the documented and tested minimum is 7.5 #39508

wants to merge 1 commit into from

Conversation

wanger26
Copy link
Contributor

Change Summary

  • Enforce Gradle version to be at least of v7.5 as the documented and tested minimum Gradle version is 7.5

Issue

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 10, 2024
wilkinsona
wilkinsona requested changes Feb 11, 2024
View reviewed changes
Copy link
Member

@wilkinsona wilkinsona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you please also update SpringBootPluginIntegrationTests to match?

@wanger26
FIX BUG - Enforce Gradle version to be at least of v7.5
d4a1869 
The documented and tested minimum Gradle version is 7.5

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@wanger26
Copy link
Contributor Author

wanger26 commented Feb 11, 2024 •
edited
Loading

Thanks for the PR. Can you please also update SpringBootPluginIntegrationTests to match?

Good catch! My apologies, completely missed that test. Updated now 😎

@scottfrederick scottfrederick added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 11, 2024
@scottfrederick scottfrederick added this to the 3.1.x milestone Feb 11, 2024
@scottfrederick scottfrederick mentioned this pull request Feb 11, 2024
Closed
@scottfrederick scottfrederick changed the title FIX BUG - Enforce Gradle version to be at least of v7.5 Gradle plugin allows the use of Gradle 7.4 but the documented and tested minimum is 7.5 Feb 11, 2024
@scottfrederick scottfrederick mentioned this pull request Feb 11, 2024
Closed
scottfrederick pushed a commit that referenced this pull request Feb 11, 2024
@wanger26 @scottfrederick
Enforce Gradle version to be at least of version 7.5
7e90b49 
See gh-39508

Signed-off-by: Jakob Wanger <jakobwanger@gmail.com>
@scottfrederick scottfrederick modified the milestones: 3.1.x, 3.1.9 Feb 11, 2024
@scottfrederick
Copy link
Contributor

@wanger26 Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkinsona wilkinsona wilkinsona requested changes

Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
3.1.9
Development

Successfully merging this pull request may close these issues.
4 participants
@wanger26 @scottfrederick @wilkinsona @spring-projects-issues