@ImportTestcontainers does not work with @DataJpaTest #39960
Comments
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
changed the title
@ImportTestcontainers cannot works with @DataJpaTest
|
Thanks for the report and sample project. Although not clear from the exception message, the underlying cause is that the I've opened spring-projects/spring-framework#32470 to see if the diagnostics can be improved on the Framework side. We'll also have to see what we can do on the Boot side to avoid the problem that triggers the exception in the first place. A workaround is to make the container package com.example.demo;
import static org.assertj.core.api.Assertions.assertThat;
import javax.sql.DataSource;
import org.junit.jupiter.api.Test;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase;
import org.springframework.boot.test.autoconfigure.jdbc.AutoConfigureTestDatabase.Replace;
import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest;
import org.springframework.boot.testcontainers.context.ImportTestcontainers;
import org.springframework.boot.testcontainers.service.connection.ServiceConnection;
import org.springframework.boot.testcontainers.service.connection.ServiceConnectionAutoConfiguration;
import org.springframework.context.weaving.LoadTimeWeaverAware;
import org.springframework.instrument.classloading.LoadTimeWeaver;
import org.testcontainers.containers.PostgreSQLContainer;
import org.testcontainers.junit.jupiter.Container;
@DataJpaTest
@ImportAutoConfiguration(classes = ServiceConnectionAutoConfiguration.class)
@AutoConfigureTestDatabase(replace = Replace.NONE)
@ImportTestcontainers
public class ImportContainersTests {
@Container
@ServiceConnection
static LoadTimeWeaverAwarePostgreSQLContainer<?> container = new LoadTimeWeaverAwarePostgreSQLContainer<>("postgres");
@Autowired
private DataSource dataSource;
@Test
void test() {
assertThat(dataSource).extracting("jdbcUrl").asString().startsWith("jdbc:postgresql://");
}
static class LoadTimeWeaverAwarePostgreSQLContainer<SELF extends LoadTimeWeaverAwarePostgreSQLContainer<SELF>> extends PostgreSQLContainer<SELF> implements LoadTimeWeaverAware {
LoadTimeWeaverAwarePostgreSQLContainer(String imageName) {
super(imageName);
}
@Override
public void setLoadTimeWeaver(LoadTimeWeaver loadTimeWeaver) {
}
}
}This is horrible but it might indicate an avenue that's worth exploring for a proper fix. |
wilkinsona
added
the
for: team-meeting
|
I suppose it would also help to let the |
|
It works fine with @Configuration
static class Config {
@Bean
@ServiceConnection
PostgreSQLContainer<?> container() {
return new PostgreSQLContainer<>("postgres");
}
}We should document current limitation and guide users to work around it. |
wilkinsona
removed
the
for: team-meeting
- upgrade to spring-boot 3.2.3; - upgrade to spring-cloud 2023.0.0; - disable UserStreamTest and UserEventRepositoryTest because ImportTestcontainers annotation is not working properly with Cassandra spring-projects/spring-boot#39960
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Is it fixed by 468e246? |
wilkinsona
added
status: superseded
|
Yes. Thanks, @quaff. |
plugins { id 'java' id 'org.springframework.boot' version '3.2.3' id 'io.spring.dependency-management' version 'latest.release' } group = 'com.example' version = '0.0.1-SNAPSHOT' sourceCompatibility = '17' repositories { mavenCentral() } dependencies { implementation 'org.springframework.boot:spring-boot-starter-data-jpa' testImplementation 'org.springframework.boot:spring-boot-starter-test' testImplementation 'org.springframework.boot:spring-boot-testcontainers' testImplementation 'org.testcontainers:junit-jupiter' testImplementation 'org.testcontainers:postgresql' testRuntimeOnly 'org.junit.platform:junit-platform-launcher' testRuntimeOnly 'org.postgresql:postgresql' } tasks.named('test') { useJUnitPlatform() }will throw exception:
BTW, It works fine with
@JdbcTest.Here is reproducer importcontainers.zip
The text was updated successfully, but these errors were encountered: