Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add property to configure base time unit for Micrometer OTLP registry #36200

Closed
jonatan-ivanov opened this issue Jul 3, 2023 · 1 comment
Closed

Add property to configure base time unit for Micrometer OTLP registry #36200

jonatan-ivanov opened this issue Jul 3, 2023 · 1 comment
Assignees
@jonatan-ivanov
Labels
status: superseded An issue that has been superseded by another theme: observability Issues related to observability type: enhancement A general enhancement

Comments

@jonatan-ivanov
Copy link
Member

Micrometer added a new property to its OTLP registry to enable configuring the base time unit, see: micrometer-metrics/micrometer#3870. This should be released in 1.12.0-M1 (already available in 1.12.0-SNAPSHOT).

We should add property support for this in Boot too.
Also related: #36188
@jonatan-ivanov jonatan-ivanov added type: enhancement A general enhancement theme: observability Issues related to observability labels Jul 3, 2023
@jonatan-ivanov jonatan-ivanov added this to the 3.2.0-M1 milestone Jul 3, 2023
@jonatan-ivanov jonatan-ivanov self-assigned this Jul 3, 2023
jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Jul 12, 2023
@jonatan-ivanov
Add property for base time unit in OTLP registry
309e404 
Micrometer added a new configuration option to its OTLP registry to
enable configuring the base time unit. These changes add Boot property
support to it.

See spring-projectsgh-36200
@jonatan-ivanov jonatan-ivanov mentioned this issue Jul 12, 2023
Closed
jonatan-ivanov added a commit to jonatan-ivanov/spring-boot that referenced this issue Jul 12, 2023
@jonatan-ivanov
Add property for base time unit in OTLP registry
db2a2d9 
Micrometer added a new configuration option to its OTLP registry to
enable configuring the base time unit. These changes add Boot property
support to it.

See spring-projectsgh-36200
@snicoll
Copy link
Member

snicoll commented Jul 17, 2023

Superseded by PR #36393

@snicoll snicoll closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
@snicoll snicoll removed this from the 3.2.0-M1 milestone Jul 17, 2023
@snicoll snicoll added the status: superseded An issue that has been superseded by another label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonatan-ivanov jonatan-ivanov

Labels
status: superseded An issue that has been superseded by another theme: observability Issues related to observability type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snicoll @jonatan-ivanov