Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable incompatible tests on Linux AArch64 #30082

Closed
mhalbritter opened this issue Mar 7, 2022 · 4 comments
Closed

Disable incompatible tests on Linux AArch64 #30082

mhalbritter opened this issue Mar 7, 2022 · 4 comments
Assignees
Labels
type: task A general task
Milestone

Comments

@mhalbritter
Copy link
Contributor

When running the Spring Boot build with ./gradlew build, the EmbeddedMongoAutoConfigurationTests fail all the time. This is because Embedded Mongo has no support for Linux aarch64 (See flapdoodle-oss/de.flapdoodle.embed.mongo#379).

We should workaround this by disabling the tests if running on Linux aarch64.

@mhalbritter mhalbritter added the type: bug A general bug label Mar 7, 2022
@mhalbritter mhalbritter self-assigned this Mar 7, 2022
@mhalbritter mhalbritter added this to the 2.5.x milestone Mar 7, 2022
@mhalbritter mhalbritter changed the title Embedded mongo doesn't work on Linux aarch64 Disable EmbeddedMongoAutoConfigurationTests on Linux aarch64 Mar 7, 2022
@mhalbritter mhalbritter added type: task A general task and removed type: bug A general bug labels Mar 7, 2022
@mhalbritter mhalbritter modified the milestones: 2.5.x, 2.5.11 Mar 7, 2022
@mhalbritter
Copy link
Contributor Author

mhalbritter commented Mar 7, 2022

org.springframework.boot.web.embedded.jetty.SslServerCustomizerTests#whenHttp2IsEnabledServerConnectorsHasSslAlpnH2AndHttpConnectionFactories and org.springframework.boot.web.embedded.jetty.SslServerCustomizerTests#alpnConnectionFactoryHasNullDefaultProtocolToAllowNegotiationToHttp11 also don't work on Linux aarch64, see google/conscrypt#1051

They are now ignored on linux aarch64, too.

@wilkinsona wilkinsona changed the title Disable EmbeddedMongoAutoConfigurationTests on Linux aarch64 Disable incompatible tests on Linux AArch64 Mar 7, 2022
@wilkinsona
Copy link
Member

@sbrannen Do you think it would be worth proposing an enhancement to JUnit that provides a built-in condition for enabling/disabling tests on particular OS architectures?

mhalbritter added a commit that referenced this issue Mar 7, 2022
We'll add it back again when we need it, and delay the naming issue.

See gh-30082
@sbrannen
Copy link
Member

sbrannen commented Mar 8, 2022

Yes, I think it's worth opening an issue for the JUnit team to discuss.

Related issue, though focusing on distributions instead of architectures:

I think explicit support for architectures stands a better chance than explicit support for distributions, since I see the former as generally more useful/applicable.

@wilkinsona
Copy link
Member

Thanks, Sam!

mhalbritter added a commit that referenced this issue Mar 23, 2022
These tests use embedded mongo under the hood.

See gh-30082
izeye added a commit to izeye/spring-boot that referenced this issue Jun 28, 2022
This commit also updates related test support classes.

See spring-projectsgh-30082
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

3 participants