Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Java 16 #24402

Closed
3 tasks done
dreis2211 opened this issue Dec 8, 2020 · 5 comments
Closed
3 tasks done

Add support for Java 16 #24402

dreis2211 opened this issue Dec 8, 2020 · 5 comments
Assignees
Labels
status: superseded An issue that has been superseded by another type: task A general task

Comments

@dreis2211
Copy link
Contributor

dreis2211 commented Dec 8, 2020

Hi,

I want to raise this issue to collect/track the needed things in order for JDK 16 to work.

  • Add JavaVersion.SIXTEEN
  • Adjust TestJarCreator multi-release jar tests
  • Add build pipeline for JDK 16

Related/Required issues:

I would volunteer do this again for JDK 16 after working on JDK 14 & JDK 15 in the past. I would start - probably tomorrow - with fixing the first two points on this list. The pipeline task requires Gradle support for JDK 16, so this would need to wait a bit.

Let me know what you think.
Cheers,
Christoph

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 8, 2020
@snicoll
Copy link
Member

snicoll commented Dec 8, 2020

Ah ah, @dreis2211 this is too funny. We've discussed that very topic on the team meeting yesterday :) Sure, that sounds great and thanks a lot for your efforts!

@snicoll snicoll changed the title Support for JDK 16 Add support for Java 16 Dec 8, 2020
@snicoll snicoll added for: team-attention An issue we'd like other members of the team to review status: waiting-for-triage An issue we've not yet triaged and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 8, 2020
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Dec 10, 2020
dreis2211 added a commit to dreis2211/spring-boot that referenced this issue Dec 10, 2020
@snicoll snicoll removed the for: team-attention An issue we'd like other members of the team to review label Dec 11, 2020
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 23, 2020
@snicoll snicoll added this to the 2.4.x milestone Dec 23, 2020
@wilkinsona
Copy link
Member

I'd like to see us use Gradle's toolchain support so that we don't have to wait for their Java 16 support. We can run Gradle itself on Java 8 and compile and test with Java 16. This'll require our Java 16 CI image to contain JDK 8 and JDK 16.

@dreis2211
Copy link
Contributor Author

I talked with @snicoll earlier. I'll see what I can come up with. My current plan is to essentially replace & adjust the functionality that I once introduced for a custom buildJavaHome property. E.g. introduce a new parameter toolchainVersion, which - if available - configures the toolchain stuff inside JavaConventions. I might need a little help in the end for the CI image stuff though.

@snicoll
Copy link
Member

snicoll commented Mar 8, 2021

With the pipeline in place I think we're good with this one. Thanks again @dreis2211!

@snicoll snicoll closed this as completed Mar 8, 2021
@snicoll snicoll modified the milestones: 2.4.x, 2.4.4 Mar 8, 2021
@wilkinsona wilkinsona removed the type: enhancement A general enhancement label Mar 8, 2021
@wilkinsona wilkinsona added the type: task A general task label Mar 8, 2021
@wilkinsona wilkinsona removed this from the 2.4.4 milestone Mar 8, 2021
@wilkinsona wilkinsona added the status: superseded An issue that has been superseded by another label Mar 8, 2021
@wilkinsona
Copy link
Member

I've moved this one out of 2.4.4 as I think it's been superseded by some other issues and PRs:

The last one will make the support "official" as it'll update the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: superseded An issue that has been superseded by another type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants