-
Notifications
You must be signed in to change notification settings - Fork 40.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #42174 from eddumelendez
* pr/42174: Add OpenTelemetry Logging Service Connection from LgtmStackContainer and Docker Compose Closes gh-42174
- Loading branch information
Showing
7 changed files
with
180 additions
and
3 deletions.
There are no files selected for viewing
40 changes: 40 additions & 0 deletions
40
...tlp/GrafanaOpenTelemetryLoggingDockerComposeConnectionDetailsFactoryIntegrationTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.docker.compose.service.connection.otlp; | ||
|
||
import org.springframework.boot.actuate.autoconfigure.logging.opentelemetry.otlp.OtlpLoggingConnectionDetails; | ||
import org.springframework.boot.actuate.autoconfigure.opentelemetry.otlp.Transport; | ||
import org.springframework.boot.docker.compose.service.connection.test.DockerComposeTest; | ||
import org.springframework.boot.testsupport.container.TestImage; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Integration tests for {@link OpenTelemetryLoggingDockerComposeConnectionDetailsFactory} | ||
* using {@link TestImage#GRAFANA_OTEL_LGTM}. | ||
* | ||
* @author Eddú Meléndez | ||
*/ | ||
class GrafanaOpenTelemetryLoggingDockerComposeConnectionDetailsFactoryIntegrationTests { | ||
|
||
@DockerComposeTest(composeFile = "otlp-compose.yaml", image = TestImage.GRAFANA_OTEL_LGTM) | ||
void runCreatesConnectionDetails(OtlpLoggingConnectionDetails connectionDetails) { | ||
assertThat(connectionDetails.getUrl(Transport.HTTP)).startsWith("http://").endsWith("/v1/logs"); | ||
assertThat(connectionDetails.getUrl(Transport.GRPC)).startsWith("http://").endsWith("/v1/logs"); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
...on/otlp/GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactoryIntegrationTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.testcontainers.service.connection.otlp; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.testcontainers.grafana.LgtmStackContainer; | ||
import org.testcontainers.junit.jupiter.Container; | ||
import org.testcontainers.junit.jupiter.Testcontainers; | ||
|
||
import org.springframework.beans.factory.annotation.Autowired; | ||
import org.springframework.boot.actuate.autoconfigure.logging.opentelemetry.otlp.OtlpLoggingAutoConfiguration; | ||
import org.springframework.boot.actuate.autoconfigure.logging.opentelemetry.otlp.OtlpLoggingConnectionDetails; | ||
import org.springframework.boot.actuate.autoconfigure.opentelemetry.otlp.Transport; | ||
import org.springframework.boot.autoconfigure.ImportAutoConfiguration; | ||
import org.springframework.boot.testcontainers.service.connection.ServiceConnection; | ||
import org.springframework.boot.testsupport.container.TestImage; | ||
import org.springframework.context.annotation.Configuration; | ||
import org.springframework.test.context.junit.jupiter.SpringJUnitConfig; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactory}. | ||
* | ||
* @author Eddú Meléndez | ||
*/ | ||
@SpringJUnitConfig | ||
@Testcontainers(disabledWithoutDocker = true) | ||
class GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactoryIntegrationTests { | ||
|
||
@Container | ||
@ServiceConnection | ||
static final LgtmStackContainer container = TestImage.container(LgtmStackContainer.class); | ||
|
||
@Autowired | ||
private OtlpLoggingConnectionDetails connectionDetails; | ||
|
||
@Test | ||
void connectionCanBeMadeToOpenTelemetryContainer() { | ||
assertThat(this.connectionDetails.getUrl(Transport.GRPC)) | ||
.isEqualTo("%s/v1/logs".formatted(container.getOtlpGrpcUrl())); | ||
assertThat(this.connectionDetails.getUrl(Transport.HTTP)) | ||
.isEqualTo("%s/v1/logs".formatted(container.getOtlpHttpUrl())); | ||
} | ||
|
||
@Configuration(proxyBeanMethods = false) | ||
@ImportAutoConfiguration(OtlpLoggingAutoConfiguration.class) | ||
static class TestConfiguration { | ||
|
||
} | ||
|
||
} |
67 changes: 67 additions & 0 deletions
67
...service/connection/otlp/GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactory.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* Copyright 2012-2024 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.boot.testcontainers.service.connection.otlp; | ||
|
||
import org.testcontainers.grafana.LgtmStackContainer; | ||
|
||
import org.springframework.boot.actuate.autoconfigure.logging.opentelemetry.otlp.OtlpLoggingConnectionDetails; | ||
import org.springframework.boot.actuate.autoconfigure.opentelemetry.otlp.Transport; | ||
import org.springframework.boot.testcontainers.service.connection.ContainerConnectionDetailsFactory; | ||
import org.springframework.boot.testcontainers.service.connection.ContainerConnectionSource; | ||
import org.springframework.boot.testcontainers.service.connection.ServiceConnection; | ||
|
||
/** | ||
* {@link ContainerConnectionDetailsFactory} to create | ||
* {@link OtlpLoggingConnectionDetails} from a | ||
* {@link ServiceConnection @ServiceConnection}-annotated {@link LgtmStackContainer} using | ||
* the {@code "grafana/otel-lgtm"} image. | ||
* | ||
* @author Eddú Meléndez | ||
*/ | ||
class GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactory | ||
extends ContainerConnectionDetailsFactory<LgtmStackContainer, OtlpLoggingConnectionDetails> { | ||
|
||
GrafanaOpenTelemetryLoggingContainerConnectionDetailsFactory() { | ||
super(ANY_CONNECTION_NAME, | ||
"org.springframework.boot.actuate.autoconfigure.logging.opentelemetry.otlp.OtlpLoggingAutoConfiguration"); | ||
} | ||
|
||
@Override | ||
protected OtlpLoggingConnectionDetails getContainerConnectionDetails( | ||
ContainerConnectionSource<LgtmStackContainer> source) { | ||
return new OpenTelemetryLoggingContainerConnectionDetails(source); | ||
} | ||
|
||
private static final class OpenTelemetryLoggingContainerConnectionDetails | ||
extends ContainerConnectionDetails<LgtmStackContainer> implements OtlpLoggingConnectionDetails { | ||
|
||
private OpenTelemetryLoggingContainerConnectionDetails(ContainerConnectionSource<LgtmStackContainer> source) { | ||
super(source); | ||
} | ||
|
||
@Override | ||
public String getUrl(Transport transport) { | ||
String url = switch (transport) { | ||
case HTTP -> getContainer().getOtlpHttpUrl(); | ||
case GRPC -> getContainer().getOtlpGrpcUrl(); | ||
}; | ||
return "%s/v1/logs".formatted(url); | ||
} | ||
|
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters